Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force_unwrapping rule catches IBOutlet Collections in swiftlint 0.9.1 #546

Closed
tapi opened this issue Feb 17, 2016 · 4 comments
Closed

force_unwrapping rule catches IBOutlet Collections in swiftlint 0.9.1 #546

tapi opened this issue Feb 17, 2016 · 4 comments
Labels
bug Unexpected and reproducible misbehavior.

Comments

@tapi
Copy link

tapi commented Feb 17, 2016

IBOutlets are always force unwrapped and generally the force_unwrap rule ignores them.

However it appears as though with swiftlint 0.9.1 it is catching IBOutlet collections. ie.

@IBOutlet weak var constraint: NSLayoutConstraint!

is ignored by the linter but

@IBOutlet var constraints: [NSLayoutConstraint]!

is not ignored
@tapi tapi changed the title force_unwrapping rule catches IBOutlet Collections force_unwrapping rule catches IBOutlet Collections Feb 17, 2016
@tapi tapi changed the title force_unwrapping rule catches IBOutlet Collections force_unwrapping rule catches IBOutlet Collections in swiftlint 0.9.1 Feb 17, 2016
@brandenr
Copy link

I would think the IBOutelts should be caught by the force unwrap rule. They actually can be nil at times and cause a crash

@ikesyo
Copy link
Contributor

ikesyo commented Feb 17, 2016

They are not forced unwrapping, but are defining properties of implicitly unwrapped optional. Those two are not the same. So force_unwrapping rule is catching IUO would be the real issue.

@norio-nomura norio-nomura added the bug Unexpected and reproducible misbehavior. label Feb 17, 2016
@norio-nomura
Copy link
Collaborator

Thanks for filing an issue.
This behavior has been changed by #537.
Maybe we need another approach for force_unwrapping.🤔

norio-nomura added a commit that referenced this issue Feb 19, 2016
@norio-nomura
Add failing false positive examples to ForceUnwrappingRule's descri…
753dad8 
…ption

#546, #547
This was referenced Feb 19, 2016
Merged
Closed
@norio-nomura
Copy link
Collaborator

I opened PR #552 for fixing the issue #546, #547.
Feedback is welcome.

norio-nomura added a commit that referenced this issue Feb 21, 2016
@norio-nomura
Add failing false positive examples to ForceUnwrappingRule's descri…
f80373f 
…ption

#546, #547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected and reproducible misbehavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@norio-nomura @tapi @ikesyo @brandenr