Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule instances only have static properties/methods #8

Closed
aarondaub opened this issue May 18, 2015 · 2 comments
Closed

Rule instances only have static properties/methods #8

aarondaub opened this issue May 18, 2015 · 2 comments

Comments

@aarondaub
Copy link

Since all functions/properties on Rule instances are static, we have to validate each rule against the file then remove irrelevant results.

Would it be better to construct an array of Rules, filter that, then call map on the resulting subarray?
@aarondaub
Copy link
Author

After finally being able to build the project and seeing what pain my ad-configurationFile PR wrought onto the repo I think this is necessary to let the Rules to apply be determined dynamically.

@aarondaub aarondaub mentioned this issue May 19, 2015
Merged
@aarondaub
Copy link
Author

Addressed by PR 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aarondaub