Have the Rule protocol define its members as non-static so that we ca… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n pass around instances of Rule
|
I agree that being able to pass around rule instances will make passing them around much simpler. Could you add an entry to |
|
@jpsim how do you want to handle merging? Should we squash the commits? |
jpsim
added a commit
that referenced
this pull request
May 19, 2015
Define Rule protocol's members as non-static
|
Merged. For future notice, please add changelog entries as I did here: a196c6a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n pass around instances of Rule
@jpsim