Disable/re-enable rules from within source code comments. Fixes #4. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| extension File { | ||
| public func regions() -> [Region] { | ||
| let nsStringContents = contents as NSString | ||
| let commands = matchPattern("swiftlint:(enable|disable):force_cast") |
There was a problem hiding this comment.
shouldn't force_cast be .+ and then captured to determine which rule it is?
There was a problem hiding this comment.
the rule capturing was already being done by NSScanner, but I had accidentally hardcoded force_cast in here as part of my testing.
|
Good enough! |
jpsim
added a commit
that referenced
this pull request
Sep 1, 2015
Disable/re-enable rules from within source code comments. Fixes #4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft addressing #4. Still need to write some tests, but seems to be working from what I can tell from manually testing. /cc @keith @segiddins