Add ability to toggle Rules on and off. #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarondaub
changed the title
|
@jpsim re our discussion regarding Rule_ -> ParameterizedRule:. Should ASTRule conform to Rule or ParameterizedRule? Will ASTRules ever NOT have parameters? If so, should we have a ParameterizedASTRule or just have those have an empty array of parameters? |
Update master
|
Fixed merge conflicts. ASTRules conform to ParameterizedRule, is that the correct behaviour? |
aarondaub
force-pushed
the
ad-dynamicRules
branch
from
97b96ec to
46290b2
Compare
|
Closing in favor of #24, at @aarondaub's request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jpsim this addresses #1. It branches off of ad-unstaticifyRules as I needed those changes.
My solution to the type alias problem may be controversial and I'm definitely up for alternative suggestions.