Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in empty_enum_arguments rule #1598

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1597

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.35s vs 0.33s on master (6% slower)
📖 Linting Alamofire with this PR took 2.28s vs 2.28s on master (0% slower)
📖 Linting Firefox with this PR took 9.91s vs 9.83s on master (0% slower)
📖 Linting Kickstarter with this PR took 12.57s vs 12.94s on master (2% faster)
📖 Linting Moya with this PR took 0.67s vs 0.65s on master (3% slower)
📖 Linting Nimble with this PR took 1.29s vs 1.28s on master (0% slower)
📖 Linting Quick with this PR took 0.42s vs 0.42s on master (0% slower)
📖 Linting Realm with this PR took 2.01s vs 2.01s on master (0% slower)
📖 Linting SourceKitten with this PR took 0.86s vs 0.85s on master (1% slower)
📖 Linting Sourcery with this PR took 2.73s vs 2.68s on master (1% slower)
📖 Linting Swift with this PR took 9.21s vs 9.24s on master (0% faster)
📖 Linting WordPress with this PR took 9.58s vs 9.53s on master (0% slower)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #1598 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
+ Coverage   84.24%   84.26%   +0.01%     
==========================================
  Files         192      192              
  Lines        9979     9991      +12     
==========================================
+ Hits         8407     8419      +12     
  Misses       1572     1572
Impacted Files Coverage Δ
...ftLintFramework/Rules/EmptyEnumArgumentsRule.swift 97.05% <100%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f23bdc0...7e256f4. Read the comment docs.

@marcelofabri marcelofabri merged commit 2ac58aa into master Jun 2, 2017
@marcelofabri marcelofabri deleted the bugfix-1597 branch June 2, 2017 19:35
@jpsim
Copy link
Collaborator

jpsim commented Jun 2, 2017

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants