Vertical whitespace msg fix #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
CHANGELOG.md
Outdated
| @@ -38,6 +38,23 @@ | |||
| [Otávio Lima](https://github.com/otaviolima) | |||
| [#1710](https://github.com/realm/SwiftLint/issues/1710) | |||
|
|
|||
| ## 0.22.0: Coffee Maker | |||
There was a problem hiding this comment.
Why is this here?
This change should be added to Master section.
| @@ -11,6 +11,8 @@ import XCTest | |||
|
|
|||
| class VerticalWhitespaceRuleTests: XCTestCase { | |||
|
|
|||
| private let ruleID = "vertical_whitespace" | |||
There was a problem hiding this comment.
you should use VerticalWhitespaceRule.description.identifier
| } | ||
| } | ||
|
|
||
| func testVilationMessageWithDefaultConfiguration() { |
| } | ||
| let allViolations = violations("let aaaa = 0\n\n\n\nlet bbb = 2\n", config: config) | ||
| let verticalWhiteSpaceViolation = allViolations.first(where: { $0.ruleDescription.identifier == ruleID }) | ||
| if let violation = verticalWhiteSpaceViolation { |
There was a problem hiding this comment.
this test will silently fail if no violation is triggered. It should fail instead.
| func testVilationMessageWithDefaultConfiguration() { | ||
| let allViolations = violations("let aaaa = 0\n\n\n\nlet bbb = 2\n") | ||
| let verticalWhiteSpaceViolation = allViolations.first(where: { $0.ruleDescription.identifier == ruleID }) | ||
| if let violation = verticalWhiteSpaceViolation { |
There was a problem hiding this comment.
this test will silently fail if no violation is triggered. It should fail instead.
| for eachLine in linesSections { | ||
| let start = eachLine.lastLine.index - eachLine.linesToRemove | ||
| indexOfLinesToDelete.append(contentsOf: start..<eachLine.lastLine.index) | ||
| for section in linesSections { |
There was a problem hiding this comment.
You need to add tests for this change as well.
CHANGELOG.md
Outdated
| ##### Bug Fixes | ||
|
|
||
| * Fix the warning message of `vertical-whitespace` rule to display the maximum empty lines allowed if `maxEmptyLines` is greater than 1. | ||
| * Fix the autocorrection of `vertical-whitespace` rule to keep the `maxEmptyLines` in the cleaned section. |
CHANGELOG.md
Outdated
| ##### Bug Fixes | ||
|
|
||
| * Fix the warning message of `vertical-whitespace` rule to display the maximum empty lines allowed if `maxEmptyLines` is greater than 1. | ||
| * Fix the autocorrection of `vertical-whitespace` rule to keep the `maxEmptyLines` in the cleaned section. |
There was a problem hiding this comment.
requires two trailing spaces as described in CONTRIBUTING.md: https://github.com/realm/SwiftLint/blob/master/CONTRIBUTING.md#tracking-changes
marcelofabri
requested changes
Aug 13, 2017
|
Thanks, @hossamghareeb! I just did some minor changes in 7f5e236. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #1763
Fixes:
maxEmptyLines.maxEmptyLinesand not 1.