Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no explicit boolean comparision rule #1853

Closed

Conversation

sammy-SC
Copy link
Contributor

Implements #1502

@sammy-SC sammy-SC closed this Sep 27, 2017
@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.43s vs 0.43s on master (0% slower)
📖 Linting Alamofire with this PR took 3.38s vs 3.26s on master (3% slower)
📖 Linting Firefox with this PR took 14.11s vs 14.14s on master (0% faster)
📖 Linting Kickstarter with this PR took 22.77s vs 19.97s on master (14% slower)
📖 Linting Moya with this PR took 1.62s vs 1.45s on master (11% slower)
📖 Linting Nimble with this PR took 2.58s vs 1.75s on master (47% slower)
📖 Linting Quick with this PR took 0.77s vs 0.56s on master (37% slower)
📖 Linting Realm with this PR took 3.68s vs 2.82s on master (30% slower)
📖 Linting SourceKitten with this PR took 1.21s vs 1.0s on master (20% slower)
📖 Linting Sourcery with this PR took 5.34s vs 4.48s on master (19% slower)
📖 Linting Swift with this PR took 18.11s vs 14.07s on master (28% slower)
📖 Linting WordPress with this PR took 13.03s vs 11.64s on master (11% slower)

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Sep 27, 2017

Codecov Report

Merging #1853 into master will decrease coverage by 44.16%.
The diff coverage is 94.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1853       +/-   ##
===========================================
- Coverage   88.89%   44.73%   -44.17%     
===========================================
  Files         236      237        +1     
  Lines       11513    11621      +108     
===========================================
- Hits        10235     5199     -5036     
- Misses       1278     6422     +5144
Impacted Files Coverage Δ
...e/SwiftLintFramework/Rules/SortedImportsRule.swift 100% <100%> (ø) ⬆️
Tests/SwiftLintFrameworkTests/RulesTests.swift 100% <100%> (ø) ⬆️
...mework/Rules/NoExplicitBooleanComparisonRule.swift 86.04% <86.04%> (ø)
.../SwiftLintFrameworkTests/AttributesRuleTests.swift 0% <0%> (-100%) ⬇️
Tests/SwiftLintFrameworkTests/TodoRuleTests.swift 0% <0%> (-100%) ⬇️
.../SwiftLintFramework/Models/ViolationSeverity.swift 0% <0%> (-100%) ⬇️
...rameworkTests/UnusedOptionalBindingRuleTests.swift 0% <0%> (-100%) ⬇️
...iftLintFrameworkTests/TrailingCommaRuleTests.swift 0% <0%> (-100%) ⬇️
...tLintFramework/Models/RuleList+Documentation.swift 0% <0%> (-100%) ⬇️
...tFramework/Extensions/CharacterSet+LinuxHack.swift 0% <0%> (-100%) ⬇️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8677f...fe3405a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants