Don’t validate local vars in let_var_whitespace rule #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #2022 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 254 254
Lines 14863 14863
Branches 968 968
=======================================
Hits 13326 13326
Misses 1519 1519
Partials 18 18
Continue to review full report at Codecov.
|
|
I definitely want the rule to apply to local variables. In fact, that's more important to me (and I wrote this rule). Maybe it could be a config option? |
|
@Uncommon feel free to open an issue to track this 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #2021
I know that the original idea was to validate local variables, but that seemed not so useful in a real project (SwiftLint itself), triggering a lot of warnings.
Since this didn't work until Swift 4.1 anyways, I've just removed it for now. If people feel that this is useful, we can add it back as a configuration.