Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in empty_enum_arguments rule when using closures #2044

Merged
merged 1 commit into from
Feb 11, 2018
Merged

Fix false positive in empty_enum_arguments rule when using closures #2044

merged 1 commit into from
Feb 11, 2018

Conversation

marcelofabri
Copy link
Collaborator

Fixes #2041

@SwiftLintBot
Copy link

SwiftLintBot commented Feb 11, 2018

12 Messages
📖 Linting Aerial with this PR took 0.44s vs 0.41s on master (7% slower)
📖 Linting Alamofire with this PR took 3.41s vs 3.36s on master (1% slower)
📖 Linting Firefox with this PR took 13.18s vs 13.02s on master (1% slower)
📖 Linting Kickstarter with this PR took 20.92s vs 20.88s on master (0% slower)
📖 Linting Moya with this PR took 1.98s vs 1.95s on master (1% slower)
📖 Linting Nimble with this PR took 1.9s vs 1.99s on master (4% faster)
📖 Linting Quick with this PR took 0.58s vs 0.58s on master (0% slower)
📖 Linting Realm with this PR took 3.54s vs 3.6s on master (1% faster)
📖 Linting SourceKitten with this PR took 1.12s vs 1.13s on master (0% faster)
📖 Linting Sourcery with this PR took 5.0s vs 4.94s on master (1% slower)
📖 Linting Swift with this PR took 14.12s vs 14.0s on master (0% slower)
📖 Linting WordPress with this PR took 15.2s vs 15.55s on master (2% faster)

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Feb 11, 2018

Codecov Report

Merging #2044 into master will decrease coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2044      +/-   ##
==========================================
- Coverage   89.66%   89.63%   -0.03%     
==========================================
  Files         256      256              
  Lines       14889    14886       -3     
  Branches      969      969              
==========================================
- Hits        13350    13343       -7     
- Misses       1521     1525       +4     
  Partials       18       18
Impacted Files Coverage Δ
...ftLintFramework/Rules/EmptyEnumArgumentsRule.swift 94.05% <83.33%> (-4.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e155d...8c2c4b0. Read the comment docs.

@marcelofabri marcelofabri merged commit 3b80e15 into realm:master Feb 11, 2018
@marcelofabri marcelofabri deleted the bugfix-2041 branch February 11, 2018 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants