Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives in attributes rule with Swift 4.1 #2148

Merged
merged 1 commit into from
Apr 7, 2018

Conversation

marcelofabri
Copy link
Collaborator

Fixes #2125 and #2141

This was a side effect of swiftlang/swift#12086.

@SwiftLintBot
Copy link

12 Messages
📖 Linting Aerial with this PR took 0.52s vs 0.49s on master (6% slower)
📖 Linting Alamofire with this PR took 4.15s vs 4.48s on master (7% faster)
📖 Linting Firefox with this PR took 15.53s vs 20.37s on master (23% faster)
📖 Linting Kickstarter with this PR took 21.97s vs 29.14s on master (24% faster)
📖 Linting Moya with this PR took 2.09s vs 2.46s on master (15% faster)
📖 Linting Nimble with this PR took 2.02s vs 2.44s on master (17% faster)
📖 Linting Quick with this PR took 0.6s vs 0.72s on master (16% faster)
📖 Linting Realm with this PR took 4.02s vs 4.52s on master (11% faster)
📖 Linting SourceKitten with this PR took 1.24s vs 1.46s on master (15% faster)
📖 Linting Sourcery with this PR took 5.39s vs 5.74s on master (6% faster)
📖 Linting Swift with this PR took 18.17s vs 20.28s on master (10% faster)
📖 Linting WordPress with this PR took 20.97s vs 19.83s on master (5% slower)

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #2148 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2148      +/-   ##
==========================================
+ Coverage   89.87%   89.89%   +0.01%     
==========================================
  Files         266      266              
  Lines       15385    15395      +10     
  Branches     1012     1013       +1     
==========================================
+ Hits        13828    13840      +12     
+ Misses       1537     1535       -2     
  Partials       20       20
Impacted Files Coverage Δ
...urce/SwiftLintFramework/Rules/AttributesRule.swift 98.16% <100%> (+0.07%) ⬆️
Source/SwiftLintFramework/Models/Command.swift 97.82% <0%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c501107...d432176. Read the comment docs.

@jpsim
Copy link
Collaborator

jpsim commented Apr 7, 2018

Curious that osscheck didn’t catch any of these.

@marcelofabri
Copy link
Collaborator Author

@jpsim we’re using Swift 4.0 on osscheck

@jpsim
Copy link
Collaborator

jpsim commented Apr 7, 2018

Right. It’ll be good to run it locally to diff 4.0.3 with 4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants