Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive Configs #307

Merged
merged 24 commits into from
Jan 3, 2016
Merged

Recursive Configs #307

merged 24 commits into from
Jan 3, 2016

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Jan 2, 2016

Picked up from @scottrhoyt's excellent work in #301, but cherry picking the commits rather than merging the master branch into it, and making some minor tweaks.

scottrhoyt and others added 24 commits January 2, 2016 15:41
@scottrhoyt @jpsim
Added String extensions.
43edbdb
@scottrhoyt @jpsim
Added recursive search for configurations.
9188d16
@scottrhoyt @jpsim
Use new String extension.
bd26e4c
@scottrhoyt @jpsim
Added use_nested_configs option for .swiftlint.yml (defaults to no).
4b0b4d7
@scottrhoyt @jpsim
Refactor Configuration initialization from yml for efficiency.
ae15223
@scottrhoyt @jpsim
Silently load nested configurations.
0d4fce9
@scottrhoyt @jpsim
Revert "Silently load nested configurations."
f35f3d4 
This reverts commit d8c418e.
@scottrhoyt @jpsim
Silence the logging inside of Configuration.init instead.
4361adc
@scottrhoyt @jpsim
Updated comments.
88749c1
@scottrhoyt @jpsim
Enable test coverage generation.
bc880f3
@scottrhoyt @jpsim
Added isEqual for Rule and ParameterizedRule. Made Configuration and …
fcf9396 
…RuleParameter conform to Equatable. Wrote tests to verify. All done in support of testing recursive configuration file search.
@scottrhoyt @jpsim
Moved == implementation for [Rule] to more appropriate spot. Wrote mi…
7b2f4bf 
…ssing test.
@scottrhoyt @jpsim
Extracted Configuration mocks to test class constants.
369ef23
@scottrhoyt @jpsim
Tested merge.
5b02350
@scottrhoyt @jpsim
Added Nested Configuration testing.
314f72a
@scottrhoyt @jpsim
Replace manual config mocks with file-driven.
39a0953
@scottrhoyt @jpsim
No longer needed RuleMocks at global scope.
246adf6
@scottrhoyt @jpsim
Cleaned up project mock *.yml's.
6c2adce
@scottrhoyt @jpsim
Updated CHANGELOG
00ebbb4
@scottrhoyt @jpsim
Update README and CHANGELOG
e082b6f
@jpsim
readme fixes
864d8d6
@jpsim
no longer mirror some NSString methods in a String extension
281a4dc
@jpsim
minor refactorings
fc3545b
@jpsim
fix ConfigurationTests
1e553a5 
by moving String.stringByAppendingPathComponent to the test

also remove @testable annotation because it is unused
jpsim added a commit that referenced this pull request Jan 3, 2016
@jpsim
Merge pull request #307 from realm/jp-sh-recursive-configs
c6f464a 
Recursive Configs
@jpsim jpsim merged commit c6f464a into master Jan 3, 2016
@jpsim jpsim deleted the jp-sh-recursive-configs branch January 3, 2016 00:12
@jpsim jpsim mentioned this pull request Jan 3, 2016
Closed
3 tasks
@scottrhoyt scottrhoyt mentioned this pull request Jan 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpsim @scottrhoyt