Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SyntaxRules Opt-In #3094

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Make SyntaxRules Opt-In #3094

merged 1 commit into from
Feb 10, 2020

Conversation

marcelofabri
Copy link
Collaborator

I committed them as default rules by mistake

@marcelofabri marcelofabri merged commit b303cd6 into master Feb 10, 2020
@marcelofabri marcelofabri deleted the mf-make-rules-opt-in branch February 10, 2020 00:20
@SwiftLintBot
Copy link

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
12 Messages
📖 Linting Aerial with this PR took 0.54s vs 0.54s on master (0% slower)
📖 Linting Alamofire with this PR took 0.88s vs 0.87s on master (1% slower)
📖 Linting Firefox with this PR took 3.95s vs 3.82s on master (3% slower)
📖 Linting Kickstarter with this PR took 6.48s vs 6.19s on master (4% slower)
📖 Linting Moya with this PR took 0.5s vs 0.58s on master (13% faster)
📖 Linting Nimble with this PR took 0.61s vs 0.59s on master (3% slower)
📖 Linting Quick with this PR took 0.33s vs 0.32s on master (3% slower)
📖 Linting Realm with this PR took 1.06s vs 1.01s on master (4% slower)
📖 Linting SourceKitten with this PR took 0.52s vs 0.51s on master (1% slower)
📖 Linting Sourcery with this PR took 2.66s vs 2.61s on master (1% slower)
📖 Linting Swift with this PR took 7.7s vs 7.75s on master (0% faster)
📖 Linting WordPress with this PR took 6.69s vs 6.6s on master (1% slower)

Here's an example of your CHANGELOG entry:

* Make SyntaxRules Opt-In.  
  [marcelofabri](https://github.com/marcelofabri)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

jpsim added a commit that referenced this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants