Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnusedDeclarationRule] Work around SR-11985 #3363

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Sep 22, 2020

No description provided.

@SwiftLintBot
Copy link

SwiftLintBot commented Sep 22, 2020

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
12 Messages
📖 Linting Aerial with this PR took 0.81s vs 0.8s on master (1% slower)
📖 Linting Alamofire with this PR took 1.04s vs 0.97s on master (7% slower)
📖 Linting Firefox with this PR took 3.89s vs 3.75s on master (3% slower)
📖 Linting Kickstarter with this PR took 6.57s vs 6.4s on master (2% slower)
📖 Linting Moya with this PR took 0.52s vs 0.51s on master (1% slower)
📖 Linting Nimble with this PR took 0.61s vs 0.58s on master (5% slower)
📖 Linting Quick with this PR took 0.31s vs 0.31s on master (0% slower)
📖 Linting Realm with this PR took 1.12s vs 1.13s on master (0% faster)
📖 Linting SourceKitten with this PR took 0.51s vs 0.49s on master (4% slower)
📖 Linting Sourcery with this PR took 2.63s vs 2.65s on master (0% faster)
📖 Linting Swift with this PR took 8.07s vs 8.02s on master (0% slower)
📖 Linting WordPress with this PR took 7.33s vs 7.21s on master (1% slower)

Here's an example of your CHANGELOG entry:

* [UnusedDeclarationRule] Work around SR-11985.  
  [jpsim](https://github.com/jpsim)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2020

Codecov Report

Merging #3363 into master will increase coverage by 0.00%.
The diff coverage is 95.45%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3363   +/-   ##
=======================================
  Coverage   90.52%   90.53%           
=======================================
  Files         417      417           
  Lines       20434    20456   +22     
=======================================
+ Hits        18498    18519   +21     
- Misses       1936     1937    +1     
Impacted Files Coverage Δ
...ntFramework/Rules/Lint/UnusedDeclarationRule.swift 86.95% <95.45%> (+1.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67b0f2...9baf463. Read the comment docs.

@jpsim jpsim marked this pull request as ready for review September 22, 2020 16:36
@jpsim jpsim merged commit 494796b into master Sep 22, 2020
@jpsim jpsim deleted the unuseddeclarationrule-work-around-sr-11985 branch September 22, 2020 17:00
optionalendeavors added a commit to optionalendeavors/SwiftLint that referenced this pull request Oct 4, 2020
* master-upstream: (98 commits)
  Fix some false positives in rule `explicit_self` (realm#3368)
  Update SourceKitten to 0.30.1 (realm#3367)
  Fix issues with analyzer rules, Xcode 12 & SwiftUI (realm#3366)
  Add empty changelog section
  release 0.40.3
  Fix false positives for 'multiple_closures_with_trailing_closure' (realm#3353)
  [UnusedDeclarationRule] Work around SR-11985 (realm#3363)
  Revert "Fix finding the nested config when a single file path is passed (realm#3342)" (realm#3362)
  [CONTRIBUTING] Add building & running tips (realm#3360)
  Fix finding the nested config when a single file path is passed (realm#3342)
  Include Linux zip in list of GitHub release binaries (realm#3350)
  [UnusedDeclarationRule] Add more tests (realm#3359)
  Test CI with official Swift 5.3 release (realm#3356)
  Don't mark `@NSApplicationMain` or `@UIApplicationMain` classes as unused (realm#3355)
  [Fix] `UnusedCaptureListRule`: implicit self in @escaping closures (realm#3352)
  Skip correcting files with parser diagnostics (realm#3349)
  [SwiftLintFile] Remove lock in favor of UUID (realm#3347)
  [UnusedDeclarationRule] Speed up and detect more dead code (realm#3340)
  Add empty changelog section
  release 0.40.2
  ...

# Conflicts:
#	Source/swiftlint/Helpers/LintableFilesVisitor.swift
optionalendeavors added a commit to optionalendeavors/SwiftLint that referenced this pull request Oct 4, 2020
* master: (98 commits)
  Fix some false positives in rule `explicit_self` (realm#3368)
  Update SourceKitten to 0.30.1 (realm#3367)
  Fix issues with analyzer rules, Xcode 12 & SwiftUI (realm#3366)
  Add empty changelog section
  release 0.40.3
  Fix false positives for 'multiple_closures_with_trailing_closure' (realm#3353)
  [UnusedDeclarationRule] Work around SR-11985 (realm#3363)
  Revert "Fix finding the nested config when a single file path is passed (realm#3342)" (realm#3362)
  [CONTRIBUTING] Add building & running tips (realm#3360)
  Fix finding the nested config when a single file path is passed (realm#3342)
  Include Linux zip in list of GitHub release binaries (realm#3350)
  [UnusedDeclarationRule] Add more tests (realm#3359)
  Test CI with official Swift 5.3 release (realm#3356)
  Don't mark `@NSApplicationMain` or `@UIApplicationMain` classes as unused (realm#3355)
  [Fix] `UnusedCaptureListRule`: implicit self in @escaping closures (realm#3352)
  Skip correcting files with parser diagnostics (realm#3349)
  [SwiftLintFile] Remove lock in favor of UUID (realm#3347)
  [UnusedDeclarationRule] Speed up and detect more dead code (realm#3340)
  Add empty changelog section
  release 0.40.2
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants