Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix superfluous disable command for custom rules #4760

Conversation

mildm8nnered
Copy link
Collaborator

Alternative fix for #4754

See also #4755

@SwiftLintBot
Copy link

1 Warning
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
18 Messages
📖 Linting Aerial with this PR took 1.1s vs 1.1s on main (0% slower)
📖 Linting Alamofire with this PR took 1.41s vs 1.41s on main (0% slower)
📖 Linting Brave with this PR took 7.59s vs 7.58s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 2.99s vs 3.0s on main (0% faster)
📖 Linting Firefox with this PR took 9.49s vs 9.46s on main (0% slower)
📖 Linting Kickstarter with this PR took 10.33s vs 10.3s on main (0% slower)
📖 Linting Moya with this PR took 0.57s vs 0.57s on main (0% slower)
📖 Linting NetNewsWire with this PR took 3.21s vs 3.2s on main (0% slower)
📖 Linting Nimble with this PR took 0.62s vs 0.62s on main (0% slower)
📖 Linting PocketCasts with this PR took 7.7s vs 7.67s on main (0% slower)
📖 Linting Quick with this PR took 0.24s vs 0.24s on main (0% slower)
📖 Linting Realm with this PR took 11.98s vs 11.98s on main (0% slower)
📖 Linting SourceKitten with this PR took 0.47s vs 0.45s on main (4% slower)
📖 Linting Sourcery with this PR took 2.33s vs 2.34s on main (0% faster)
📖 Linting Swift with this PR took 4.78s vs 4.75s on main (0% slower)
📖 Linting VLC with this PR took 1.42s vs 1.4s on main (1% slower)
📖 Linting Wire with this PR took 9.12s vs 9.07s on main (0% slower)
📖 Linting WordPress with this PR took 11.48s vs 11.43s on main (0% slower)

Here's an example of your CHANGELOG entry:

* Fix superfluous disable command for custom rules.  
  [mildm8nnered](https://github.com/mildm8nnered)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@mildm8nnered mildm8nnered deleted the mildm8nnered-fix-superfluous_disable_command_for_custom_rules branch April 17, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants