Add new `private_swiftui_state_property` rule#4769

Merged

SimplyDanny merged 16 commits intorealm:mainfrom mt00chikin:private_swiftui_state_rule

Jul 28, 2023

+258

Commits on Jul 28, 2023

Create rule that requires SwiftUI state properties to be private
thompsonmatthew-heb
committed
Update deprecated types from previous SwiftSyntax version and relocate AttribteListSyntax extension to rule declaration to prevent linter integration warning in project
thompsonmatthew-heb
committed
Update CHANGELOG
thompsonmatthew-heb
committed
Inline examples and add violation marker for the triggering example
thompsonmatthew-heb
committed
Only apply the private SwiftUI state property rule to SwiftUI View types. Added a new non-triggering example for reference
thompsonmatthew-heb
committed
Skip any declarations other than structs for this rule
thompsonmatthew-heb
committed
Correctly handle class View conformance and don't use a set for inherited types
thompsonmatthew-heb
committed
Exclude specific declarations from consideration on the rule and add new example cases
thompsonmatthew-heb
committed
Additional MR feedback. Now the rule also can be applied to actors and the function to check for the view protocol has been extracted to a function
thompsonmatthew-heb
committed
Update CHANGELOG after rebase
thompsonmatthew-heb
committed
Move conformsToViewProtocol function to TypeInheritanceClauseSyntax
thompsonmatthew-heb
committed
Modify rule visitor to capture the current context and only apply if inside of an App, Scene, or View type declaration
thompsonmatthew-heb
committed
Update header docs and description
thompsonmatthew-heb
committed
Refactor rule to keep track of the node hierarchy so that nested types don't inadvertently affect the state of their parent
thompsonmatthew-heb
committed
Use SwiftLint's Stack type instead of managing an array
thompsonmatthew-heb
committed
Fix typo
thompsonmatthew-heb
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new `private_swiftui_state_property` rule#4769

Commits on Jul 28, 2023

Create rule that requires SwiftUI state properties to be private

Update deprecated types from previous SwiftSyntax version and relocate AttribteListSyntax extension to rule declaration to prevent linter integration warning in project

Update CHANGELOG

Inline examples and add violation marker for the triggering example

Only apply the private SwiftUI state property rule to SwiftUI View types. Added a new non-triggering example for reference

Skip any declarations other than structs for this rule

Correctly handle class View conformance and don't use a set for inherited types

Exclude specific declarations from consideration on the rule and add new example cases

Additional MR feedback. Now the rule also can be applied to actors and the function to check for the view protocol has been extracted to a function

Update CHANGELOG after rebase

Move conformsToViewProtocol function to TypeInheritanceClauseSyntax

Modify rule visitor to capture the current context and only apply if inside of an App, Scene, or View type declaration

Update header docs and description

Refactor rule to keep track of the node hierarchy so that nested types don't inadvertently affect the state of their parent

Use SwiftLint's Stack type instead of managing an array

Fix typo