-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore the second operands of binary left shift operations #5174
Merged
SimplyDanny
merged 8 commits into
realm:main
from
mildm8nnered:mildm8nnered-ignore-bitwise-operators
Aug 29, 2023
Merged
Ignore the second operands of binary left shift operations #5174
SimplyDanny
merged 8 commits into
realm:main
from
mildm8nnered:mildm8nnered-ignore-bitwise-operators
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to be failing CI for reasons unrelated to this branch. |
Yes, the GitHub token expired. It will hopefully be updated shortly. |
LowAmmo
reviewed
Aug 14, 2023
Source/SwiftLintBuiltInRules/Rules/Idiomatic/NoMagicNumbersRule.swift
Outdated
Show resolved
Hide resolved
LowAmmo
suggested changes
Aug 15, 2023
LowAmmo
reviewed
Aug 15, 2023
LowAmmo
approved these changes
Aug 15, 2023
LowAmmo
approved these changes
Aug 15, 2023
SimplyDanny
reviewed
Aug 26, 2023
Source/SwiftLintBuiltInRules/Rules/Idiomatic/NoMagicNumbersRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/NoMagicNumbersRule.swift
Outdated
Show resolved
Hide resolved
SimplyDanny
reviewed
Aug 27, 2023
Source/SwiftLintBuiltInRules/Rules/Idiomatic/NoMagicNumbersRule.swift
Outdated
Show resolved
Hide resolved
SimplyDanny
approved these changes
Aug 27, 2023
LowAmmo
approved these changes
Aug 28, 2023
mildm8nnered
force-pushed
the
mildm8nnered-ignore-bitwise-operators
branch
from
August 29, 2023 19:30
d2c7f5f
to
6bda105
Compare
LowAmmo
suggested changes
Aug 29, 2023
LowAmmo
approved these changes
Aug 29, 2023
Thank you for the discussions, implementation and review to both of you, @LowAmmo and @mildm8nnered! |
KS1019
pushed a commit
to KS1019/SwiftLint
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5171, at least in part.
Will no longer generate any warnings. Only the left shift operator will receive this treatment, and only for its second operand.