Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the second operands of binary left shift operations #5174

Merged

Conversation

mildm8nnered
Copy link
Collaborator

@mildm8nnered mildm8nnered commented Aug 13, 2023

Resolves #5171, at least in part.

struct LogType: OptionSet {
    /// Returns the raw bitmask value of the option and satisfies the `RawRepresentable` protocol.
    public let rawValue: UInt
    public static let operatingSystem: LogType= LogType(rawValue: 1 << 0)
    public static let debugConsole: LogType= LogType(rawValue: 1 << 1)
    public static let file: LogType= LogType(rawValue: 1 << 2)
    public static let inMemory: LogType= LogType(rawValue: 1 << 3)
    public static let testing: LogType= ulogLogType(rawValue: 1 << 4)
    public static let visual: LogType= LogType(rawValue: 1 << 5)
    public static let reporting: LogType= LogType(rawValue: 1 << 6)
    public static let other: LogType= LogType(rawValue: 1 << 7)

    public init(rawValue: UInt) {
        self.rawValue = rawValue
    }
}

Will no longer generate any warnings. Only the left shift operator will receive this treatment, and only for its second operand.

@mildm8nnered mildm8nnered marked this pull request as ready for review August 13, 2023 19:23
@mildm8nnered
Copy link
Collaborator Author

Seems to be failing CI for reasons unrelated to this branch.

@SimplyDanny
Copy link
Collaborator

Seems to be failing CI for reasons unrelated to this branch.

Yes, the GitHub token expired. It will hopefully be updated shortly.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mildm8nnered mildm8nnered force-pushed the mildm8nnered-ignore-bitwise-operators branch from d2c7f5f to 6bda105 Compare August 29, 2023 19:30
CHANGELOG.md Outdated Show resolved Hide resolved
@SwiftLintBot
Copy link

SwiftLintBot commented Aug 29, 2023

180 Messages
📖 Linting Aerial with this PR took 1.12s vs 1.11s on main (0% slower)
📖 Linting Alamofire with this PR took 1.47s vs 1.46s on main (0% slower)
📖 Linting Brave with this PR took 8.41s vs 8.37s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 4.14s vs 4.13s on main (0% slower)
📖 Linting Firefox with this PR took 9.87s vs 9.82s on main (0% slower)
📖 Linting Kickstarter with this PR took 10.61s vs 10.52s on main (0% slower)
📖 Linting Moya with this PR took 0.61s vs 0.59s on main (3% slower)
📖 Linting NetNewsWire with this PR took 3.19s vs 3.17s on main (0% slower)
📖 Linting Nimble with this PR took 0.77s vs 0.77s on main (0% slower)
📖 Linting PocketCasts with this PR took 8.39s vs 8.35s on main (0% slower)
📖 Linting Quick with this PR took 0.39s vs 0.38s on main (2% slower)
📖 Linting Realm with this PR took 11.88s vs 11.9s on main (0% faster)
📖 Linting Sourcery with this PR took 2.39s vs 2.39s on main (0% slower)
📖 Linting Swift with this PR took 5.09s vs 5.06s on main (0% slower)
📖 Linting VLC with this PR took 1.42s vs 1.42s on main (0% slower)
📖 Linting Wire with this PR took 8.7s vs 7.8s on main (11% slower)
📖 Linting WordPress with this PR took 12.58s vs 12.48s on main (0% slower)
📖 This PR fixed a violation in Brave: /Sources/BraveWallet/Blockies/Blockies.swift:17:23: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/BraveWallet/Blockies/Blockies.swift:21:20: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/BraveWallet/Blockies/Blockies.swift:21:38: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/BraveWallet/Blockies/Blockies.swift:39:41: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/BraveWallet/Blockies/Blockies.swift:39:46: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/CertificateUtilities/BraveCertificateUtils.swift:139:25: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/CertificateUtilities/CertificatePinning.swift:185:80: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/CertificateUtilities/CertificatePinning.swift:189:85: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/DesignSystem/Colors/Colors.swift:215:41: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/DesignSystem/Colors/Colors.swift:216:41: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/Shared/UIColorExtensions.swift:13:40: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/Shared/UIColorExtensions.swift:14:42: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/Shared/UIColorExtensions.swift:21:43: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/Shared/UIColorExtensions.swift:22:45: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/Shared/UIColorExtensions.swift:23:44: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/Shared/UIColorExtensions.swift:38:32: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/Shared/UIColorExtensions.swift:38:58: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Brave: /Sources/Shared/UIColorExtensions.swift:38:84: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /Core/UIColorExtension.swift:137:51: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /Core/UIColorExtension.swift:138:53: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /Core/UIColorExtension.swift:185:40: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /DuckDuckGo/ContentBlockingUpdating.swift:36:87: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /LocalPackages/DuckUI/Sources/DuckUI/Color.swift:115:33: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /LocalPackages/DuckUI/Sources/DuckUI/Color.swift:116:35: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/IPStack/Packet/IPPacket.swift:197:50: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/IPStack/Packet/IPPacket.swift:28:106: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:240:37: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:241:37: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:246:38: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:247:38: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:269:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:274:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:275:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:282:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:283:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:284:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:290:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:291:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:292:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:293:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:298:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:299:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:300:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:304:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:305:34: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:311:43: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:313:43: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:315:43: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:318:43: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:320:43: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in DuckDuckGo: /PacketTunnelProvider/ProxyServer/Utils/UInt128.swift:323:43: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /BrowserKit/Sources/Common/Extensions/ColorExtension.swift:11:46: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /BrowserKit/Sources/Common/Extensions/ColorExtension.swift:12:48: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /BrowserKit/Sources/Common/Extensions/HexExtension.swift:15:62: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /BrowserKit/Sources/SiteImageView/ImageProcessing/LetterImageGenerator.swift:122:46: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /BrowserKit/Sources/SiteImageView/ImageProcessing/LetterImageGenerator.swift:123:48: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /BrowserKit/Sources/SiteImageView/ImageProcessing/LetterImageGenerator.swift:69:20: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift:2679:95: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift:2692:95: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Browser/SearchViewController.swift:380:103: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Library/HistoryPanel/HistoryPanel+Search.swift:74:95: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /Client/Frontend/Library/HistoryPanel/HistoryPanel+Search.swift:86:95: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Firefox: /Shared/Extensions/HexExtensions.swift:20:38: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Kickstarter: /Library/UIColor.swift:16:43: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Kickstarter: /Library/UIColor.swift:17:41: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Kickstarter: /Library/UIColor.swift:7:45: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Kickstarter: /Library/UIColor.swift:8:43: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Kickstarter: /Library/UIColor.swift:9:41: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Moya: /Sources/Moya/Plugins/NetworkLoggerPlugin.swift:166:82: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Moya: /Sources/Moya/Plugins/NetworkLoggerPlugin.swift:173:87: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Moya: /Sources/Moya/Plugins/NetworkLoggerPlugin.swift:175:87: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Moya: /Sources/Moya/Plugins/NetworkLoggerPlugin.swift:177:85: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in NetNewsWire: /Shared/Extensions/IconImage.swift:151:30: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in NetNewsWire: /Shared/Extensions/IconImage.swift:155:30: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Nimble: /Carthage/Checkouts/CwlPreconditionTesting/Sources/CwlPreconditionTesting/CwlDarwinDefinitions.swift:33:106: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Nimble: /Tests/NimbleTests/Matchers/ContainTest.swift:136:49: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Nimble: /Tests/NimbleTests/Matchers/ContainTest.swift:137:49: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Nimble: /Tests/NimbleTests/Matchers/ContainTest.swift:138:49: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/DataModel/Sources/PocketCastsDataModel/Private/Managers/Util/DBUtils.swift:45:48: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/Color+Hex.swift:11:42: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/Color+Hex.swift:13:41: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/Color+Hex.swift:15:36: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/UIColorExtension.swift:19:57: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/UIColorExtension.swift:20:59: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/UIColorExtension.swift:23:58: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/UIColorExtension.swift:24:60: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/UIColorExtension.swift:25:59: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/UIColorExtension.swift:28:60: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/UIColorExtension.swift:29:62: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/UIColorExtension.swift:32:63: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/UIColorExtension.swift:33:65: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /Modules/Utils/Sources/PocketCastsUtils/Extensions/UI/UIColorExtension.swift:34:64: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in PocketCasts: /podcasts/SwiftUI/Motion.swift:76:55: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Realm: /Realm/Tests/Swift/SwiftPropertyTypeTest.swift:58:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Realm: /Realm/Tests/Swift/SwiftPropertyTypeTest.swift:59:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Realm: /Realm/Tests/Swift/SwiftPropertyTypeTest.swift:60:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Realm: /Realm/Tests/Swift/SwiftPropertyTypeTest.swift:62:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Realm: /Realm/Tests/Swift/SwiftPropertyTypeTest.swift:88:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Realm: /Realm/Tests/Swift/SwiftPropertyTypeTest.swift:89:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Realm: /Realm/Tests/Swift/SwiftPropertyTypeTest.swift:91:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ObjectAccessorTests.swift:905:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ObjectAccessorTests.swift:906:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ObjectAccessorTests.swift:907:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Realm: /RealmSwift/Tests/ObjectAccessorTests.swift:909:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/private/SwiftPrivateLibcExtras/SwiftPrivateLibcExtras.swift:163:21: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Backtracing/Context.swift:299:40: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Backtracing/Context.swift:300:40: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Backtracing/Elf.swift:100:53: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Backtracing/FramePointerUnwinder.swift:116:30: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Task.swift:423:43: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Task.swift:433:72: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Task.swift:440:21: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Task.swift:447:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Task.swift:455:21: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Task.swift:462:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Task.swift:470:21: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Task.swift:477:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Task.swift:487:21: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Task.swift:494:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/TaskGroup.swift:1221:31: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Windows/WinSDK.swift:186:84: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/Windows/WinSDK.swift:193:56: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Availability.swift:108:27: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Availability.swift:109:28: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Bool.swift:117:33: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Hasher.swift:82:58: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/core/StringNormalization.swift:37:27: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/core/StringObject.swift:508:48: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UTF16.swift:308:44: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UTF16.swift:318:40: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UTF16.swift:321:36: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnicodeData.swift:163:43: warning: No Magic Numbers Violation: Magic numbers should be replaced by named constants (no_magic_numbers)
⚠️ Danger found 180 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 149.

Generated by 🚫 Danger

@SimplyDanny SimplyDanny enabled auto-merge (squash) August 29, 2023 19:59
@SimplyDanny SimplyDanny merged commit 097ddd7 into realm:main Aug 29, 2023
@SimplyDanny
Copy link
Collaborator

Thank you for the discussions, implementation and review to both of you, @LowAmmo and @mildm8nnered!

@mildm8nnered mildm8nnered deleted the mildm8nnered-ignore-bitwise-operators branch August 30, 2023 18:03
KS1019 pushed a commit to KS1019/SwiftLint that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no_magic_number - Ignore numbers involved in bit-wise operations (like << or >> or | or &)
4 participants