-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop triggering no_magic_numbers
rule on literals used in ranges
#5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimplyDanny
force-pushed
the
magic-numbers-in-ranges
branch
2 times, most recently
from
January 20, 2024 09:54
3d00b16
to
17fab3f
Compare
SimplyDanny
force-pushed
the
magic-numbers-in-ranges
branch
from
January 20, 2024 10:18
17fab3f
to
5cdbaa6
Compare
All OSS findings are valid. The performance drop is due to expression folding. As folded trees are cached, this is only a one-time cost. The more rules in a configuration require folded expressions the more the effort spent for folding becomes neglectable. |
u-abyss
pushed a commit
to u-abyss/SwiftLint
that referenced
this pull request
Feb 11, 2024
kohtenko
pushed a commit
to kohtenko/SwiftLint
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5430.