-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the superfluous_disable_command when running the analyzer #5522
Enable the superfluous_disable_command when running the analyzer #5522
Conversation
Generated by 🚫 Danger |
1d48f3b
to
5c557cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good. Thanks!
Can the proper functionally somehow be proven by a test?
Managed to work out how to get the analyzer to run and to find a reasonable spot for it, along with the other superfluous disable command tests. |
Addresses #4792. Surprisingly easy.
superfluous_disable_command
ignores rules that aren't enabled, so you canswiftlint:disable
analyzer rules, and they will be ignored when linting. Similarly, when analyzing,superfluous_disable_command
will ignore any non analyzer rules.