Update SourceKitten, SwiftyTextTable and support `swift test` #555

norio-nomura · 2016-02-21T11:25:34Z

norio-nomura · 2016-02-21T14:04:20Z

On jpsim/SourceKitten#176, I wrote changelog entry in Breaking.
How should I write changelog entry on this?

norio-nomura · 2016-03-17T09:56:41Z

Now, this depends on jpsim/SourceKitten#178. After that will be merged to master and tagged next SourceKitten, this PR will be modified to referencing them in submodule, Cartfile and Package.swift.

norio-nomura · 2016-03-17T15:06:17Z

jpsim/SourceKitten#178 contains supporting swift test. So I tested adapting SwiftLint to swift test on this PR, but it seems we need updating https://github.com/scottrhoyt/SwiftyTextTable to adapting swift test before that.
I'd write another PR for adapting SwiftLint to swift test.

scottrhoyt · 2016-03-18T19:27:35Z

@norio-nomura @jpsim updated SwiftyTextTable with JP's PR. Cut a new release 0.3.0. There is a small breaking change in 0.3.0, but if you apply this patch after updating, you'll be good to go:

diff --git a/Source/swiftlint/Commands/RulesCommand.swift b/Source/swiftlint/Commands/RulesCommand.swift
index 4286221..da1489c 100644
--- a/Source/swiftlint/Commands/RulesCommand.swift
+++ b/Source/swiftlint/Commands/RulesCommand.swift
@@ -90,12 +90,13 @@ extension TextTable {
                 }
                 return nil
             }()
-            addRow(ruleID,
+            addRow([
+                ruleID,
                 (rule is OptInRule) ? "yes" : "no",
                 (rule is CorrectableRule) ? "yes" : "no",
                 configuredRule != nil ? "yes" : "no",
                 (configuredRule ?? rule).configurationDescription
-            )
+            ])
         }
     }
 }

patch.diff.zip

norio-nomura · 2016-03-19T00:56:50Z

@scottrhoyt @jpsim Thanks!
Now, this PR contains supporting swift test.
But on local testing, swift compiler crashes randomly and not yet success swift test.

…ork`

https://github.com/apple/swift-corelibs-xctest/blob/master/README.md#additional-considerations-for-swift-on-linux

norio-nomura · 2016-03-19T01:32:48Z

SPM test failed on https://travis-ci.org/realm/SwiftLint/jobs/117049352#L762

/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2016-03-01-a.xctoolchain/usr/bin/swift test
:0: error: unable to build node: '<Package.test>' (node is produced by multiple commands; e.g., '<swiftlint.exe>' and '%,��test>m/SwiftL��R����R��p��R��R��R��R��')

On local machine:

% swift test
<unknown>:0: error: unable to build node: '<Package.test>' (node is produced by multiple commands; e.g., '<swiftlint.exe>' and '')
error: exit(1): swift-build-tool -f /Users/norio/Documents/workspace/github/SwiftLint/.build/debug.yaml test

😞

norio-nomura · 2016-03-19T04:56:07Z

Filed: https://bugs.swift.org/browse/SR-989

norio-nomura · 2016-03-19T09:36:35Z

At last, swift build --configuration release has succeeded by swift-DEVELOPMENT-SNAPSHOT-2016-03-01-a. Previous snapshots crashed on swift build --configuration release.

The durations of linting Carthage-0.15.2,
swift-2.1.1 (Xcode 7.2.1):

/usr/local/bin/swiftlint lint --config ~/.swiftlint-test.yml  14.36s user 0.85s system 79% cpu 19.045 total

swift-DEVELOPMENT-SNAPSHOT-2016-03-01-a:

../SwiftLint/.build/release/swiftlint lint --config ~/.swiftlint-test.yml  11.59s user 0.90s system 78% cpu 15.941 total

https://bugs.swift.org/browse/SR-989

norio-nomura · 2016-03-25T01:23:44Z

CHANGELOG.md

+
+* Failed to launch swiftlint when Xcode.app was placed at non standard path.  
+  [Norio Nomura](https://github.com/norio-nomura)
+  [#593](https://github.com/realm/SwiftLint/issues/593)


Entries in Enhancements and Bug Fixes are essentially same. Would it be a single entry?

It's fine to keep them separate.

norio-nomura · 2016-03-25T01:26:30Z

I disabled make spm_test on Travis-CI because I think that the failing is caused by swift-test's bug. https://bugs.swift.org/browse/SR-989

jpsim · 2016-03-25T04:58:11Z

This is fine. 👍

norio-nomura · 2016-03-30T01:53:27Z

Thanks for merging! 🙏

mxcl · 2016-03-31T18:03:14Z

I have confirmed that swiftlang/swift-package-manager#224 seems to fix this, however you must couple it with the recently completed: swiftlang/swift-package-manager#230 in order to build Swift 2 projects against the latest swift-build

jpsim · 2016-03-31T18:28:54Z

Thanks for the update @mxcl!

norio-nomura · 2016-04-04T14:58:46Z

@mxcl Hi, I built swiftpm(e702428) and tested as following:

$ export SWIFT_EXEC=/Library/Developer/Toolchains/swift-2.2.1-SNAPSHOT-2016-03-28-a.xctoolchain/usr/bin/swiftc
$ cd ~/github/SwiftLint
$ ~/github/Apple/swiftpm/.build/debug/swift-build
Compiling Swift Module 'Result' (2 sources)
Compiling Swift Module 'SWXMLHash' (2 sources)
Compiling Swift Module 'Yaml' (6 sources)
Compiling Swift Module 'SwiftyTextTable' (1 sources)
…
<SNIP>
…
Compiling Swift Module 'swiftlint' (8 sources)
Linking .build/debug/swiftlint
~/github/Apple/swiftpm/.build/debug/swift-build  68.84s user 11.04s system 203% cpu 39.286 total
$  ~/github/Apple/swiftpm/.build/debug/swift-test
Compiling Swift Module 'SwiftyTextTableTestSuite' (1 sources)
Compiling Swift Module 'SwiftLintFrameworkTestSuite' (16 sources)
Compiling Swift Module 'SourceKittenFrameworkTestSuite' (12 sources)
Linking .build/debug/SwiftyTextTable.xctest/Contents/MacOS/SwiftyTextTable
Linking .build/debug/SourceKitten.xctest/Contents/MacOS/SourceKitten
Linking .build/debug/SwiftLint.xctest/Contents/MacOS/SwiftLint
Test Suite 'All tests' started at 2016-04-04 23:51:01.625
Test Suite 'SourceKitten.xctest' started at 2016-04-04 23:51:01.626
Test Suite 'ClangTranslationUnitTests' started at 2016-04-04 23:51:01.626
Test Case '-[SourceKittenFrameworkTestSuite.ClangTranslationUnitTests testBasicObjectiveCDocs]' started.
Test Case '-[SourceKittenFrameworkTestSuite.ClangTranslationUnitTests testBasicObjectiveCDocs]' passed (0.972 seconds).
Test Case '-[SourceKittenFrameworkTestSuite.ClangTranslationUnitTests testParsesObjectiveCHeaderFilesAndXcodebuildArguments]' started.
Test Case '-[SourceKittenFrameworkTestSuite.ClangTranslationUnitTests testParsesObjectiveCHeaderFilesAndXcodebuildArguments]' passed (0.000 seconds).
Test Case '-[SourceKittenFrameworkTestSuite.ClangTranslationUnitTests testRealmObjectiveCDocs]' started.
…
<SNIP>
…
Test Case '-[SourceKittenFrameworkTestSuite.SwiftDocsTests testSubscript]' failed (0.017 seconds).
Test Suite 'SwiftDocsTests' failed at 2016-04-04 23:52:02.019.
     Executed 3 tests, with 2 failures (0 unexpected) in 0.112 (0.112) seconds
Test Suite 'SyntaxTests' started at 2016-04-04 23:52:02.019
Test Case '-[SourceKittenFrameworkTestSuite.SyntaxTests testGenerateSameSyntaxMapFileAndContents]' started.
Test Case '-[SourceKittenFrameworkTestSuite.SyntaxTests testGenerateSameSyntaxMapFileAndContents]' passed (0.017 seconds).
Test Case '-[SourceKittenFrameworkTestSuite.SyntaxTests testPrintEmptySyntax]' started.
Test Case '-[SourceKittenFrameworkTestSuite.SyntaxTests testPrintEmptySyntax]' passed (0.001 seconds).
Test Case '-[SourceKittenFrameworkTestSuite.SyntaxTests testSubscript]' started.
Test Case '-[SourceKittenFrameworkTestSuite.SyntaxTests testSubscript]' passed (0.001 seconds).
Test Case '-[SourceKittenFrameworkTestSuite.SyntaxTests testSyntaxMapPrintValidJSON]' started.
Test Case '-[SourceKittenFrameworkTestSuite.SyntaxTests testSyntaxMapPrintValidJSON]' passed (0.001 seconds).
Test Suite 'SyntaxTests' passed at 2016-04-04 23:52:02.039.
     Executed 4 tests, with 0 failures (0 unexpected) in 0.019 (0.019) seconds
Test Suite 'SourceKitten.xctest' failed at 2016-04-04 23:52:02.039.
     Executed 40 tests, with 7 failures (0 unexpected) in 60.409 (60.413) seconds
Test Suite 'All tests' failed at 2016-04-04 23:52:02.039.
     Executed 40 tests, with 7 failures (0 unexpected) in 60.409 (60.414) seconds

The build passes. But swift-test runs SourceKittenFrameworkTestSuite only that is one of dependencies of SwiftLint. I tried specifying SwiftLintFrameworkTestSuite module and could not run that as:

$ ~/github/Apple/swiftpm/.build/debug/swift-test SwiftLintFrameworkTestSuite
Test Suite 'Selected tests' started at 2016-04-04 23:55:38.145
Test Suite 'Selected tests' passed at 2016-04-04 23:55:38.145.
     Executed 0 tests, with 0 failures (0 unexpected) in 0.000 (0.001) seconds

Is this known issue?

mxcl · 2016-04-04T17:19:53Z

@norio-nomura thanks, will fix.

norio-nomura · 2016-04-05T02:02:44Z

@mxcl Thanks! I filed https://bugs.swift.org/browse/SR-1159

This was referenced Feb 21, 2016

Use xcode-select -p (dlsym() approach) jpsim/SourceKitten#176

Closed

[WIP] Use xcode-select -p (weak link approach) #529

Closed

norio-nomura mentioned this pull request Mar 17, 2016

A different approach to library wrapper generation and testing jpsim/SourceKitten#185

Merged

norio-nomura force-pushed the nn-use-xcode-select-p-dlsym branch from 1b72967 to e69d79f Compare March 17, 2016 09:37

jpsim mentioned this pull request Mar 17, 2016

Move tests scottrhoyt/SwiftyTextTable#8

Merged

norio-nomura added 6 commits March 19, 2016 09:31

Update SourceKitten to 0.11.0

90be48e

Remove linking libclang.dylib and sourcekitd.framework

c1ee9f4

[SPM] Remove spm_bootstrap and spm_teardown from Makefile

cf15800

[SPM] Update to swift-DEVELOPMENT-SNAPSHOT-2016-03-01-a

ee44ced

Cleanup FRAMEWORK_SEARCH_PATHS and LIBRARY_SEARCH_PATHS

6dbef0b

[SPM] Update SourceKitten to 0.11.0

fa78d39

norio-nomura force-pushed the nn-use-xcode-select-p-dlsym branch from e69d79f to 67bb05f Compare March 19, 2016 00:54

norio-nomura changed the title ~~[WIP] Use xcode-select -p (dlsym() approach)~~ [WIP] Update SourceKitten, SwiftyTextTable and support swift test Mar 19, 2016

norio-nomura added 4 commits March 19, 2016 10:05

[SPM] Move Source/SwiftLintFrameworkTests to `Tests/SwiftLintFramew…

5caeb07

…ork`

[SPM] Update Package.swift

070bbb8

Update SwiftyTextTable to 0.3.0

0a6faaf

[SPM] Update Makefile to using swift test

55fce2c

norio-nomura force-pushed the nn-use-xcode-select-p-dlsym branch from 67bb05f to 55fce2c Compare March 19, 2016 01:05

norio-nomura added 2 commits March 19, 2016 10:11

Add Tests to include in .swiftlint.yml

0408f1f

[SPM] Remove obsoleted XCTestCaseProvider.allTests

ff29a2c

https://github.com/apple/swift-corelibs-xctest/blob/master/README.md#additional-considerations-for-swift-on-linux

norio-nomura added 2 commits March 25, 2016 10:18

[SPM] Disable make spm_test on Travis-CI until SR-989 will be fixed

46ba7cb

https://bugs.swift.org/browse/SR-989

Add changelog entry

d23cf71

norio-nomura mentioned this pull request Mar 25, 2016

Still cannot run swiftlint on circleci #593

Closed

norio-nomura reviewed Mar 25, 2016
View reviewed changes

norio-nomura changed the title ~~[WIP] Update SourceKitten, SwiftyTextTable and support swift test~~ Update SourceKitten, SwiftyTextTable and support swift test Mar 25, 2016

jpsim merged commit 3f350ec into master Mar 30, 2016

jpsim deleted the nn-use-xcode-select-p-dlsym branch March 30, 2016 00:49

jpsim mentioned this pull request Jun 16, 2016

Print nicer error messages on dynamic linking errors #17

Closed

This was referenced May 4, 2022

[SR-1159] swift test runs test module one of dependencies instead of current package swiftlang/swift-package-manager#5305

Closed

[SR-989] swift test produces error "<unknown>:0: error: unable to build node" swiftlang/swift-package-manager#5309

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update SourceKitten, SwiftyTextTable and support `swift test` #555

Update SourceKitten, SwiftyTextTable and support `swift test` #555

norio-nomura commented Feb 21, 2016

norio-nomura commented Feb 21, 2016

norio-nomura commented Mar 17, 2016

norio-nomura commented Mar 17, 2016

scottrhoyt commented Mar 18, 2016

norio-nomura commented Mar 19, 2016

norio-nomura commented Mar 19, 2016

norio-nomura commented Mar 19, 2016

norio-nomura commented Mar 19, 2016

norio-nomura Mar 25, 2016

jpsim Mar 25, 2016

norio-nomura commented Mar 25, 2016

jpsim commented Mar 25, 2016

norio-nomura commented Mar 30, 2016

mxcl commented Mar 31, 2016

jpsim commented Mar 31, 2016

norio-nomura commented Apr 4, 2016

mxcl commented Apr 4, 2016

norio-nomura commented Apr 5, 2016

Update SourceKitten, SwiftyTextTable and support swift test #555

Update SourceKitten, SwiftyTextTable and support swift test #555

Conversation

norio-nomura commented Feb 21, 2016

norio-nomura commented Feb 21, 2016

norio-nomura commented Mar 17, 2016

norio-nomura commented Mar 17, 2016

scottrhoyt commented Mar 18, 2016

norio-nomura commented Mar 19, 2016

norio-nomura commented Mar 19, 2016

norio-nomura commented Mar 19, 2016

norio-nomura commented Mar 19, 2016

norio-nomura Mar 25, 2016

Choose a reason for hiding this comment

jpsim Mar 25, 2016

Choose a reason for hiding this comment

norio-nomura commented Mar 25, 2016

jpsim commented Mar 25, 2016

norio-nomura commented Mar 30, 2016

mxcl commented Mar 31, 2016

jpsim commented Mar 31, 2016

norio-nomura commented Apr 4, 2016

mxcl commented Apr 4, 2016

norio-nomura commented Apr 5, 2016

Update SourceKitten, SwiftyTextTable and support `swift test` #555

Update SourceKitten, SwiftyTextTable and support `swift test` #555