Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place corrections optionally into violations #5680

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

SimplyDanny
Copy link
Collaborator

This avoids maintaining two lists of objects.

This avoids maintaining two lists of objects.
@SwiftLintBot
Copy link

SwiftLintBot commented Jul 20, 2024

2 Warnings
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR may need tests.
17 Messages
📖 Linting Aerial with this PR took 0.66s vs 0.66s on main (0% slower)
📖 Linting Alamofire with this PR took 0.91s vs 0.91s on main (0% slower)
📖 Linting Brave with this PR took 5.3s vs 5.33s on main (0% faster)
📖 Linting DuckDuckGo with this PR took 3.09s vs 3.02s on main (2% slower)
📖 Linting Firefox with this PR took 8.19s vs 8.17s on main (0% slower)
📖 Linting Kickstarter with this PR took 6.93s vs 6.93s on main (0% slower)
📖 Linting Moya with this PR took 0.4s vs 0.4s on main (0% slower)
📖 Linting NetNewsWire with this PR took 1.81s vs 1.85s on main (2% faster)
📖 Linting Nimble with this PR took 0.56s vs 0.57s on main (1% faster)
📖 Linting PocketCasts with this PR took 6.17s vs 6.18s on main (0% faster)
📖 Linting Quick with this PR took 0.33s vs 0.34s on main (2% faster)
📖 Linting Realm with this PR took 3.42s vs 3.42s on main (0% slower)
📖 Linting Sourcery with this PR took 1.78s vs 1.76s on main (1% slower)
📖 Linting Swift with this PR took 3.13s vs 3.17s on main (1% faster)
📖 Linting VLC with this PR took 0.94s vs 0.94s on main (0% slower)
📖 Linting Wire with this PR took 12.24s vs 12.18s on main (0% slower)
📖 Linting WordPress with this PR took 8.13s vs 8.07s on main (0% slower)

Here's an example of your CHANGELOG entry:

* Place corrections optionally into violations.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@SimplyDanny SimplyDanny merged commit 238415b into realm:main Jul 20, 2024
12 checks passed
@SimplyDanny SimplyDanny deleted the merge-violation-and-correction branch July 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants