Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract new contrasted_opening_brace rule from opening_brace rule #5723

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Extract new contrasted_opening_brace rule from opening_brace rule #5723

merged 1 commit into from
Aug 3, 2024

Conversation

SimplyDanny
Copy link
Collaborator

No description provided.

@SimplyDanny SimplyDanny mentioned this pull request Aug 3, 2024
Merged
@SimplyDanny SimplyDanny force-pushed the contrasted-opening-brace branch from a76f5a2 to cbe63ed Compare August 3, 2024 15:02
@SwiftLintBot
Copy link

SwiftLintBot commented Aug 3, 2024 •
edited
Loading

332224 Warnings
⚠️ Big PR
⚠️ This PR introduced a violation in Aerial: /Aerial/App/AppDelegate.swift:12:52: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/App/AppDelegate.swift:14:21: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:100:55: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:101:53: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:119:68: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:121:33: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:132:60: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:133:39: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:13:90: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:140:56: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:142:37: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:146:16: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:154:34: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:155:69: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:163:60: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:166:72: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:173:41: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:178:12: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:182:30: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:183:105: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:203:65: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:206:20: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:249:17: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:255:59: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:256:37: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:262:61: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:263:37: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:264:48: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:266:20: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:273:52: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:277:55: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:278:37: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:279:56: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:285:55: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:286:37: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:287:90: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:288:77: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:302:59: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:303:47: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:308:58: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:309:47: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:314:62: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:315:37: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:316:47: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:317:60: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:323:62: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:324:37: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:325:47: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:326:60: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:333:72: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:334:61: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:337:62: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:344:63: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:345:59: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:348:62: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:349:40: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:351:35: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:362:58: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:365:96: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:368:41: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:378:88: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:380:41: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:389:94: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:393:41: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:404:56: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:407:111: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:410:41: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:412:52: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:423:88: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:426:41: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:436:45: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:444:35: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:446:20: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:453:51: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:471:16: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:481:50: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:482:85: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:487:162: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:491:128: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:493:64: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:494:31: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:495:45: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:496:65: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:499:45: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:504:24: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:514:77: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:517:57: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:518:37: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:520:16: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:526:104: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:527:37: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:529:65: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:530:60: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:532:20: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:533:60: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:537:120: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:547:68: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:548:37: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:549:46: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:552:60: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:553:55: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:556:20: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:564:22: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:565:55: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:566:53: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:572:15: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:57:36: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:582:27: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:585:31: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:586:32: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:593:49: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:594:42: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:596:30: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:599:40: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:602:46: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:608:32: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:62:38: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:68:34: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:69:30: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:78:41: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:80:20: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Controllers/CustomVideoController.swift:99:56: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/APISecrets.swift:15:19: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:101:22: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:107:17: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:111:38: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:112:49: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:114:16: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:119:50: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:127:51: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:129:48: warning: Contrasted Opening Brace Violation: Opening brace should be on a separate line (contrasted_opening_brace)
⚠️ Danger found 332224 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 132.
17 Messages
📖 Linting Aerial with this PR took 0.83s vs 0.81s on main (2% slower)
📖 Linting Alamofire with this PR took 1.13s vs 1.14s on main (0% faster)
📖 Linting Brave with this PR took 6.73s vs 6.64s on main (1% slower)
📖 Linting DuckDuckGo with this PR took 3.98s vs 3.89s on main (2% slower)
📖 Linting Firefox with this PR took 9.92s vs 9.94s on main (0% faster)
📖 Linting Kickstarter with this PR took 8.73s vs 8.69s on main (0% slower)
📖 Linting Moya with this PR took 0.48s vs 0.48s on main (0% slower)
📖 Linting NetNewsWire with this PR took 2.31s vs 2.25s on main (2% slower)
📖 Linting Nimble with this PR took 0.69s vs 0.68s on main (1% slower)
📖 Linting PocketCasts with this PR took 7.61s vs 7.55s on main (0% slower)
📖 Linting Quick with this PR took 0.39s vs 0.39s on main (0% slower)
📖 Linting Realm with this PR took 4.19s vs 4.24s on main (1% faster)
📖 Linting Sourcery with this PR took 2.14s vs 2.11s on main (1% slower)
📖 Linting Swift with this PR took 4.11s vs 4.03s on main (1% slower)
📖 Linting VLC with this PR took 1.15s vs 1.11s on main (3% slower)
📖 Linting Wire with this PR took 15.97s vs 15.77s on main (1% slower)
📖 Linting WordPress with this PR took 10.61s vs 10.52s on main (0% slower)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny merged commit b67e82a into realm:main Aug 3, 2024
12 checks passed
@SimplyDanny SimplyDanny deleted the contrasted-opening-brace branch August 3, 2024 16:03
@SimplyDanny
Copy link
Collaborator Author

@buresdv: Just note that I've converted the previously added option of opening_brace into its own rule with this change. In the latest 0.56.0 release, you find the new rule as contrasted_opening_brace. This feels more natural and avoids conflicts with new options being added to opening_brace.

@marcelofabri
Copy link
Collaborator

Shouldn't contrasted_opening_brace be an opt-in rule? This caused 270k violations in our codebase.

@SimplyDanny
Copy link
Collaborator Author

Shouldn't contrasted_opening_brace be an opt-in rule? This caused 270k violations in our codebase.

It definitely should be. Fixed that and will release 0.56.1 in a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimplyDanny @SwiftLintBot @marcelofabri