Add Linux Support #963
Merged
Add Linux Support #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to help compile on Linux later
since these aren't optional on Linux, so this will help align cross-platform code.
by addressing differences in FileManager APIs on Linux and Darwin
to align Linux and Darwing code.
by adding an explicit `import Dispatch` and disabling the `atexit_b` call on Linux. This just means that we won't be able to guarantee that the print() buffer will have been flushed at program exit. Hopefully this doesn't cause too many issues.
by addressing differences in APIs between Scanner on Linux and Darwin.
…n Linux since Swift on Linux can't override methods declared in extensions yet.
since `NSRegularExpression.init()` isn't available on Linux yet.
to run all unit tests on Linux
jpsim
commented
Dec 11, 2016
| @@ -13,8 +13,8 @@ public struct PrivateUnitTestConfiguration: RuleConfiguration, Equatable { | |||
| public let identifier: String | |||
| public var name: String? | |||
| public var message = "Regex matched." | |||
| public var regex = NSRegularExpression() | |||
| public var included = NSRegularExpression() | |||
| public var regex = NSRegularExpression.forcePattern("placeholder") | |||
There was a problem hiding this comment.
If anyone can come up with a better way to do this to work with both Linux and Darwin, I'm all ears.
There was a problem hiding this comment.
maybe make them optional? 😬
There was a problem hiding this comment.
Seems obvious, but I couldn't figure it out earlier. Fixed now.
|
Maybe we should add a note about testing on Linux on https://github.com/realm/SwiftLint/blob/master/CONTRIBUTING.md#rules? |
|
@jpsim I think we should add an explanation about the |
|
This is awesome BTW 💯🎉😍 |
Current coverage is 80.96% (diff: 29.16%)@@ master #963 diff @@
==========================================
Files 123 123
Lines 5574 5774 +200
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 4685 4675 -10
- Misses 889 1099 +210
Partials 0 0
|
|
YOLO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.