Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCORE-1900 Make "next launch" metadata actions multiprocess-safe #7576

Merged
merged 7 commits into from
Jul 2, 2024
Merged

RCORE-1900 Make "next launch" metadata actions multiprocess-safe #7576

merged 7 commits into from
Jul 2, 2024

Commits on Jul 2, 2024

  1. Fix many tests which used the default scheduler on background threads 

    The libuv scheduler used in tests on non-Apple platforms does not support this.
    @tgoyne
    tgoyne committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    c1632a4 View commit details
    Browse the repository at this point in the history

  2. Read the original data for PersistedMetadataStore::update_data() insi… 

    …de the write transaction

This avoids overwriting data with stale values in multiprocess scenarios.
    @tgoyne
    tgoyne committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a9c9b6c View commit details
    Browse the repository at this point in the history

  3. Keep the metadata Realm open rather than reopening it on each use

    @tgoyne
    tgoyne committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a592484 View commit details
    Browse the repository at this point in the history

  4. Only perform launch actions if the metadata store initiated the session

    @tgoyne
    tgoyne committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    19d40bb View commit details
    Browse the repository at this point in the history

  5. Fix a race condition in a test

    @tgoyne
    tgoyne committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    82a17a4 View commit details
    Browse the repository at this point in the history

  6. Fix a race where users could get cleaned up too early

    @tgoyne
    tgoyne committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9efccbd View commit details
    Browse the repository at this point in the history

  7. Use the successfully_async_open_realm() helper in more tests

    @tgoyne
    tgoyne committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b2a419b View commit details
    Browse the repository at this point in the history