Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression and update tests #7616

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix regression and update tests #7616

merged 2 commits into from
Apr 25, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Apr 24, 2024

What, How & Why?

Fixes b4e1075
Fixes #7587.
The issue would actually have been fixed with the commit mentioned above - if the renaming had been done correctly.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@cla-bot cla-bot bot added the cla: yes label Apr 24, 2024
@jedelbo jedelbo requested a review from ironage April 24, 2024 12:53
Copy link

Pull Request Test Coverage Report for Build jorgen.edelbo_225

Details

  • 42 of 42 (100.0%) changed or added relevant lines in 2 files are covered.
  • 193 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.03%) to 91.79%

Files with Coverage Reduction New Missed Lines %
test/fuzz_tester.hpp 1 59.58%
src/realm/array_mixed.cpp 2 92.06%
src/realm/array_string.cpp 2 85.25%
src/realm/dictionary.cpp 2 85.38%
src/realm/sync/noinst/client_impl_base.cpp 2 85.51%
src/realm/sync/noinst/server/server_history.cpp 2 67.94%
src/realm/sort_descriptor.cpp 3 93.8%
src/realm/sync/instruction_applier.cpp 3 70.92%
src/realm/sync/noinst/protocol_codec.hpp 3 76.54%
src/realm/util/future.hpp 3 95.99%
Totals Coverage Status
Change from base Build 2251: -0.03%
Covered Lines: 243971
Relevant Lines: 265794

💛 - Coveralls

@jedelbo jedelbo merged commit 6728a18 into master Apr 25, 2024
38 of 39 checks passed
@jedelbo jedelbo deleted the je/RCORE-2081 branch April 25, 2024 08:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queries using query paths on Mixed values returns inconsistent results
2 participants