Build with -Werror on CI #7646
Merged
Build with -Werror on CI #7646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
commented
Apr 29, 2024
| @@ -114,7 +114,7 @@ std::optional<CollectionType> process_collection(const Property& property) | |||
| else if (is_dictionary(property.type)) { | |||
| return CollectionType::Dictionary; | |||
| } | |||
| return {}; | |||
| return std::nullopt; | |||
There was a problem hiding this comment.
This is working around a bug in GCC 9 which was fixed in 10.
| @@ -142,7 +142,7 @@ void SyncManager::do_make_logger() | |||
| REALM_ASSERT(m_logger_ptr); | |||
| } | |||
|
|
|||
| const std::shared_ptr<util::Logger>& SyncManager::get_logger() const | |||
| std::shared_ptr<util::Logger> SyncManager::get_logger() const | |||
There was a problem hiding this comment.
Returning a reference here exposed the field which was supposed to be guarded by the mutex.
| @@ -3091,7 +3091,7 @@ TEMPLATE_TEST_CASE("client reset collections of links", "[sync][pbs][client rese | |||
| {Remove{dest_pk_1}, Remove{dest_pk_2}}, {dest_pk_3, dest_pk_4}); | |||
| } | |||
| } | |||
| else if constexpr (test_type_is_set) { | |||
| if constexpr (test_type_is_set) { | |||
There was a problem hiding this comment.
With the else here, GCC determined that this if was unreachable without ever evaluating test_type_is_set and so produced an unused variable warning. This is IMO a bug in GCC, but removing the else doesn't change anything.
tgoyne
force-pushed
the
tg/werror
branch
2 times, most recently
from
1755db2
to
d010fad
Compare
Pull Request Test Coverage Report for Build thomas.goyne_324Details
💛 - Coveralls |
We used to have the Jenkins error parser that made the job fail if there were any warnings, but now we have nothing and warnings can slip through. This is a little worse as it makes the build fail immediately rather than letting it run the tests, but it's better than nothing.
jbreams
approved these changes
Apr 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have the Jenkins error parser that made the job fail if there were any warnings, but now we have nothing and warnings can slip through. This is a little worse as it makes the build fail immediately rather than letting it run the tests, but it's better than nothing.