Bump minimum deployment targets to the minimums supported by Xcode 15 #7648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submitting apps built with Xcode 14 to the app store is no longer allowed, so we no longer support building with Xcode 14.
tgoyne
commented
Apr 29, 2024
| @@ -241,13 +241,8 @@ static dispatch_queue_t reclaimer_queue; | |||
| static void ensure_reclaimer_thread_runs() | |||
| { | |||
| if (!reclaimer_timer) { | |||
| if (__builtin_available(iOS 10, macOS 12, tvOS 10, watchOS 3, *)) { | |||
There was a problem hiding this comment.
Both of these removed checks for macOS 12 were incorrect and should have been 10.12.
Pull Request Test Coverage Report for Build thomas.goyne_320Details
💛 - Coveralls |
ironage
approved these changes
Apr 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting apps built with Xcode 14 to the app store is no longer allowed, so we no longer support building with Xcode 14.