Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2140 Work around a VC++ bug in util::overload #7742

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

tgoyne
Copy link
Member

@tgoyne tgoyne commented May 28, 2024

util::overload hits https://developercommunity.visualstudio.com/t/runtime-stack-corruption-using-stdvisit/346200, which has been fixed in the latest version of Visual Studio but not the version we have installed on evergreen (including on the vsCurrent builders). We switched away from using it in one place in #4825 due to this bug, but the core tests also hit this when run with debug runtime checks enabled. This change works around the bug so that util::overload works.

@tgoyne tgoyne requested a review from ironage May 28, 2024 16:42
@tgoyne tgoyne self-assigned this May 28, 2024
@cla-bot cla-bot bot added the cla: yes label May 28, 2024
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work tracking down the source of this!

Copy link

Pull Request Test Coverage Report for Build thomas.goyne_368

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • 42 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.04%) to 90.862%

Files with Coverage Reduction New Missed Lines %
src/realm/util/file.cpp 1 78.73%
test/test_index_string.cpp 1 93.48%
src/realm/sync/noinst/client_impl_base.cpp 2 82.48%
src/realm/table.cpp 3 90.14%
src/realm/unicode.cpp 3 83.83%
test/object-store/util/sync/baas_admin_api.cpp 5 84.93%
src/realm/bplustree.cpp 7 71.41%
src/realm/sync/noinst/server/server.cpp 9 73.93%
test/fuzz_group.cpp 11 47.05%
Totals Coverage Status
Change from base Build 2348: 0.04%
Covered Lines: 214718
Relevant Lines: 236312

💛 - Coveralls

@tgoyne tgoyne merged commit 702189a into master May 28, 2024
40 checks passed
@tgoyne tgoyne deleted the tg/overload branch May 28, 2024 19:35
@github-actions github-actions bot mentioned this pull request May 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants