RCORE-2166 Fix building with Xcode 16

[tgoyne]

All of our supported versions now support always using the iphoneos SDKROOT, so we can simplify that logic and not require updates for each major version.

Cocoa has been building the SDK as C++20 for the last few years, but with Xcode 16 the mix of C++17 and C++20 is actually causing problems due to ODR violations. There's no obvious downside to just building the cocoa-specific binaries as c++20.

Fixes #7801.

[coveralls-official]

Pull Request Test Coverage Report for Build thomas.goyne_403

Details

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• 36 unchanged lines in 12 files lost coverage.
• Overall coverage decreased (-0.005%) to 90.957%

---

Files with Coverage Reduction	New Missed Lines	%
src/realm/dictionary.cpp	1	85.13%
src/realm/sync/changeset.hpp	1	75.11%
test/test_dictionary.cpp	1	99.83%
test/test_index_string.cpp	1	93.48%
test/test_util_network.cpp	1	95.56%
src/realm/db.cpp	2	92.05%
src/realm/query_expression.hpp	2	93.81%
src/realm/parser/driver.cpp	3	87.57%
test/fuzz_group.cpp	3	48.33%
src/realm/link_translator.cpp	4	76.92%

Totals
Change from base Build 2408:	-0.005%
Covered Lines:	214696
Relevant Lines:	236040

---

💛 - Coveralls

[coveralls-official]

Pull Request Test Coverage Report for Build thomas.goyne_404

Details

• 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
• 79 unchanged lines in 16 files lost coverage.
• Overall coverage decreased (-0.007%) to 90.955%

---

Files with Coverage Reduction	New Missed Lines	%
src/realm/dictionary.cpp	1	85.13%
src/realm/sort_descriptor.cpp	1	94.06%
src/realm/table_view.cpp	2	92.99%
test/object-store/util/test_file.cpp	2	86.29%
test/test_lang_bind_helper.cpp	2	93.2%
src/realm/parser/driver.cpp	3	87.57%
src/realm/link_translator.cpp	4	76.92%
src/realm/sync/noinst/server/server_history.cpp	5	63.44%
src/realm/sync/noinst/client_impl_base.cpp	6	82.47%
src/realm/bplustree.cpp	7	72.39%

Totals
Change from base Build 2408:	-0.007%
Covered Lines:	214695
Relevant Lines:	236045

---

💛 - Coveralls

[coveralls-official]

Pull Request Test Coverage Report for Build thomas.goyne_407

Details

• 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
• 67 unchanged lines in 15 files lost coverage.
• Overall coverage increased (+0.02%) to 90.979%

---

Files with Coverage Reduction	New Missed Lines	%
src/realm/dictionary.cpp	1	85.13%
src/realm/sync/noinst/changeset_index.cpp	1	79.47%
test/test_dictionary.cpp	1	99.83%
src/realm/object-store/shared_realm.cpp	2	91.89%
src/realm/query_expression.hpp	2	93.81%
src/realm/table_view.cpp	2	92.99%
src/realm/parser/driver.cpp	3	87.57%
src/realm/sync/client.cpp	3	91.78%
src/realm/sync/noinst/server/server_history.cpp	3	63.57%
src/realm/link_translator.cpp	4	76.92%

Totals
Change from base Build 2408:	0.02%
Covered Lines:	214751
Relevant Lines:	236045

---

💛 - Coveralls

[michael-wb]

Do build-apple-device.sh and/or build-cocoa.sh need updates? build-apple-device.sh seemed to be pretty lightweight and I don't think it needs any, but not sure about build-cocoa.sh.
Or are these even used anymore? They used to be used by Jenkins, but not sure if anyone still uses them.

[tgoyne]

They're used by Cocoa's GHA to build core binaries and nothing else.

[michael-wb]

LGTM