Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJS-2858: Allow both internal and public name in realm::Results::{sort, distinct} #7877

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Jul 10, 2024

What, How & Why?

From the RJS ticket:

When mapTo is used to have an alias for a property name, Realm.Results.sorted() doesn't recognize the alias leading to errors like Cannot sort on key path 'NAME': property 'PersonObject.NAME' does not exist.

This closes realm/realm-js#6779

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed
  • [ ] bindgen/spec.yml, if public C++ API changed

@kneth kneth merged commit a7479e5 into master Jul 11, 2024
19 of 41 checks passed
@kneth kneth deleted the kneth/mapped-properties-and-sorted branch July 11, 2024 11:07
@github-actions github-actions bot mentioned this pull request Jul 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remapped Property Key Not Working with Sorting
2 participants