Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2208 Regenerate testing certificates #7911

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

jbreams
Copy link
Contributor

@jbreams jbreams commented Jul 22, 2024

What, How & Why?

This does the steps in certificate-authority/HOW_TO_UPDATE.md to regenerate the testing certificates used in the sync unit tests.

☑️ ToDos

* [ ] 📝 Changelog update This is a testing-only update - there are no user-visible changes.

  • 🚦 Tests (or not relevant)
    * [ ] C-API, if public C++ API changed
    * [ ] bindgen/spec.yml, if public C++ API changed

Copy link

coveralls-official bot commented Jul 22, 2024

Pull Request Test Coverage Report for Build jonathan.reams_3356

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 99 unchanged lines in 20 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.983%

Files with Coverage Reduction New Missed Lines %
src/realm/array_mixed.cpp 1 94.02%
src/realm/index_string.cpp 1 85.17%
src/realm/sync/network/websocket.cpp 1 71.79%
src/realm/uuid.cpp 1 98.48%
test/test_query2.cpp 1 98.73%
test/test_util_network.cpp 1 95.56%
src/realm/object-store/shared_realm.cpp 2 91.89%
src/realm/sync/network/http.hpp 2 82.27%
src/realm/table_view.cpp 2 92.99%
test/test_lang_bind_helper.cpp 2 93.2%
Totals Coverage Status
Change from base Build 2508: -0.02%
Covered Lines: 216324
Relevant Lines: 237762

💛 - Coveralls

@tgoyne
Copy link
Member

tgoyne commented Jul 22, 2024

The openssl-only failing tests have a hardcoded signature that needs to be updated as well.

@jbreams
Copy link
Contributor Author

jbreams commented Jul 22, 2024

All fixed/green now. I hate that we have those hard-coded constants.

@jbreams jbreams merged commit 3352e77 into master Jul 22, 2024
41 of 42 checks passed
@jbreams jbreams deleted the jbr/regenerate_test_ca branch July 22, 2024 22:07
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants