Use the application bundle ID for keychain work #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
approved these changes
Aug 22, 2017
|
Did you really update the version of object store that .NET is using to that from an unreviewed PR? Why the rush? I'd strongly suggest waiting until object store PRs are merged before depending on them unless there's a clear reason to do otherwise. PR branches are often rebased or squashed, meaning there's no guarantee the commit you're now referencing will continue to exist. |
|
Thanks for pointing it out - that was an oversight on my part. I forgot that this PR was using a feature branch and merged it when I saw it's approved and tests pass. Will add a mental note to be more careful next time and will make sure to update to OS master once Austin's branch is merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1519
TODO