Expose [Explicit] to the world #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
requested changes
Oct 24, 2017
|
|
||
| private static bool ShouldInclude(ICustomAttributeProvider provider) | ||
| { | ||
| return provider.CustomAttributes.All(a => a.AttributeType.Name != "ExplicitAttribute"); |
There was a problem hiding this comment.
I think we should add an imported reference for ExplicitAttribute and compare against that. Otherwise we risk mistaking this for any other type with the same name but in a different namespace.
Comparing against the type name was part of the original implementation, but we ought to be safer now that this feature is public.
There was a problem hiding this comment.
Good catch, and especially with Explicit being somewhat generic. Will update it.
nirinchev
force-pushed
the
ni/explicit
branch
from
f0f38f2 to
332af9a
Compare
nirinchev
force-pushed
the
ni/explicit
branch
from
714364a to
30e3315
Compare
fealebenpae
approved these changes
Oct 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1467
TODO