Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Mixed data type #2252

Merged
merged 101 commits into from
Apr 12, 2021
Merged

Implement Mixed data type #2252

merged 101 commits into from
Apr 12, 2021

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Feb 16, 2021 •
edited by nirinchev
Loading

Add support for Mixed data type.

Fixes #2066
Fixes #2205
Fixes #2160

TODO

  • Changelog entry
  • Tests

papafe added 27 commits February 11, 2021 10:30
@papafe
Complete refactor of RealmMetadata and use of TableKey for handles
6ec51e3
@papafe
Updated core
20bf84a
@papafe
Corrected core branch
998280d
@papafe
Revert "Corrected core branch"
e18c5d5 
This reverts commit 998280d.
@papafe
Updated core commit
f372d24
@papafe
Update for CI
887952a
@papafe
Corrected core
253651f
@papafe
Small corrections
c9e14a1
@papafe
Added initial test case
fc124a4
@papafe
Added corrections
1f4054f
@papafe
Corrected name
5715f3c
@papafe
Correction to comments
eaa3611
@papafe
Added nullability of Mixed
f1caacb
@papafe
Added special case for realm value type in weaver
35feaea
@papafe
Correction to order of call
7ee6524
@papafe
Added first step
66f7bef
@papafe
Added example of test
508c475
@papafe
Added comments
16515b4
@papafe
Added missing case in equality
93858a7
@papafe
Adde ground cases
a92a620
@papafe
Added Tests for Nullable
2f23feb
@papafe
Added new tests
5cf6602
@papafe
Added table_key return value
afb6b5d
@papafe
Improved tests
9f3b982
@papafe
Simplified weaver
b06d209
@papafe
Small corrections
790a3ff
@papafe
Removed argument fromc RealmCollectionBase
d368d84
@papafe papafe marked this pull request as draft February 16, 2021 11:28
@papafe
Copy link
Contributor Author

papafe commented Feb 16, 2021 •
edited
Loading

Please note that the PR is still in draft, and that it also contains all the changes from PR #2230, as those changes are needed, and can't be merged to master yet due to a missing merge in core.

nirinchev and others added 15 commits March 29, 2021 15:34
@nirinchev
Add dictionary tests
4bfd19c
@papafe
Small corrections
1e33a76
@papafe
Merge branch 'master' into fp/mixed-2066
b5a3079 
# Conflicts:
#	Tests/Realm.Tests/Database/RealmSetTests.cs
#	Tests/Realm.Tests/Database/TestObjects.cs
@papafe
Additions
91fd11a
@papafe
Merge branch 'ni/dictionary-e2e' into fp/mixed-2066
03acc26 
# Conflicts:
#	Tests/Realm.Tests/Database/TestObjects.cs
@papafe
Added generic properties tests and Set/Dict<RealmValue> tests
6ef4d08
@papafe
Simplified tests
b7c0b10
@papafe
Updated changelog
46b759e
@papafe
Corrected collection tests for queries (and updated core version)
690c1ba
@papafe
Small corrections
5930f23
@papafe
Increased core version plus small fix
44f422a
@papafe
Small correction
15cf649
@papafe
Improvements
8279c5b
@papafe
Merge branch 'master' into fp/mixed-2066
48d02c4 
# Conflicts:
#	Tests/Realm.Tests/Database/TestObjects.cs
#	Tests/Realm.Tests/Sync/DataTypeTests.cs
#	Tests/Realm.Tests/Sync/SyncTestBase.cs
@papafe
Added corrections for sync tests
cbde2f7
@papafe
Copy link
Contributor Author

papafe commented Apr 8, 2021 •
edited
Loading

I have just verified that sync tests are passing. With this there is very little to do, and it depends on bugs/features in Core:

@nirinchev
Copy link
Member

We should also consider exposing RealmValue.ObjectType which returns AsRealmObject().ObjectSchema.Name - while users can definitely get to it themselves, I'd be quite impressed if they discover it on their own.

papafe added 3 commits April 9, 2021 15:22
@papafe
Added ObjectType
4ec51e0
@papafe
Merge branch 'master' into fp/mixed-2066
42638db 
# Conflicts:
#	Realm/Realm/DatabaseTypes/RealmDictionary.cs
#	Tests/Realm.Tests/Database/TestObjects.cs
#	Tests/Realm.Tests/Sync/SyncTestBase.cs
@papafe
From merge
37620f5
@nirinchev nirinchev mentioned this pull request Apr 9, 2021
Merged
@nirinchev nirinchev mentioned this pull request Apr 9, 2021
Merged
@nirinchev
Store the looked up schema in the binding context (#2328)
29a9aa0 
* Store the looked up schema in the context

* Bump to latest Core

* fix some warnings

* Fix build
@nirinchev
Final cleanup
665b985
@nirinchev
Merge branch 'master' into fp/mixed-2066
fd09cc1
@nirinchev nirinchev merged commit 427338b into master Apr 12, 2021
@nirinchev nirinchev deleted the fp/mixed-2066 branch April 12, 2021 11:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev left review comments

@LaPeste LaPeste LaPeste left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@papafe @nirinchev @LaPeste