Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNITY - Add missing BSON types to preserve list for Custom User Data #2519

Merged
merged 7 commits into from
Oct 26, 2021
Merged

UNITY - Add missing BSON types to preserve list for Custom User Data #2519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4f1c608
Add EnumerableInterfaceImplementerSerializer to preserved BSON types
LaPeste Jul 13, 2021
b546d7c
More missing fields
LaPeste Jul 14, 2021
e72388c
Updated changelog
LaPeste Jul 15, 2021
e1242e6
Read more env vars
LaPeste Jul 15, 2021
5258a03
Removed code meant for another branch
LaPeste Jul 15, 2021
250fac3
Test with import for Unity
LaPeste Sep 10, 2021
ed101a5
Move this issue's line to vNext
LaPeste Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* Fixed a bug that would result in a `RealmException` being thrown when opening a readonly Realm with schema that is a superset of the schema on disk. Now the code will just work and treat any classes not present in the on-disk schema to be treated as empty collections - e.g. `realm.All<ThisIsNotInOnDiskSchema>().Count == 0`. (Issue [#2619](https://github.com/realm/realm-dotnet/issues/2619))
* Fixed a bug that would create a "Documents" folder in the binary app folder when the ransomware protection in Windows is turned on. (Issue [#2685](https://github.com/realm/realm-dotnet/pull/2685))
* Fixed an issue that would cause incorrect property implementation to be generated if `PropertyChanged.Fody` runs after the Realm weaver. (Issue [#1873](https://github.com/realm/realm-dotnet/issues/1873))
* [Unity] Preserved additional constructors necessary to serialize and deserialize Custom User Data. (PR [#2519](https://github.com/realm/realm-dotnet/pull/2519))

### Compatibility
* Realm Studio: 11.0.0 or later.
Expand Down
4 changes: 4 additions & 0 deletions Realm/Realm/Helpers/SerializationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
////////////////////////////////////////////////////////////////////////////

using System;
using System.Collections.Generic;
using System.Linq;
using MongoDB.Bson;
using MongoDB.Bson.IO;
Expand Down Expand Up @@ -99,6 +100,9 @@ internal static void PreserveSerializers()
_ = new BsonArraySerializer();

_ = new ObjectSerializer();

_ = new EnumerableInterfaceImplementerSerializer<IEnumerable<object>, object>();
_ = new ExpandoObjectSerializer();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What code did you write where the ExpandoObjectSerializer was needed? As far as I know, ExpandoObject is not supported on Unity, so I'm kind of surprised we ended up with a code path that reaches its serializer, although it's possible that it's just a fallback and the bson library uses it for non-expando objects as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put the code in a repo for you to take a look.

}

public static string ToNativeJson(this object value)
Expand Down