-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Unity Weaver errors on MacOS #2737
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tom Krikorian.
|
Hey @tomkrikorian thanks for this contribution. As far as I can tell, this is moving the weaving from happening in the background to being a blocking operation. I'll need to test that a little as I am concerned about this making the editor unresponsive for a while, especially on larger projects. |
9358f74
to
5b35902
Compare
Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @tomkrikorian. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a |
@cla-bot check |
Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @tomkrikorian. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a |
The cla-bot has been summoned, and re-checked this pull request! |
Hi @nirinchev, I updated my PR with the code now running the weaving in a single Task. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Nice, I like this approach better and glad it's solving your issue. I'll merge and get this released with the next minor version. I can send you a prerelease package in the meantime to unblock you. |
Thanks @nirinchev, it's fine I'll wait for the next release :) |
Description
Fixes #2720
TODO