Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unity Weaver errors on MacOS #2737

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

tomkrikorian
Copy link
Contributor

Description

Fixes #2720

TODO

  • Changelog entry

@cla-bot
Copy link

cla-bot bot commented Nov 29, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tom Krikorian.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@nirinchev
Copy link
Member

Hey @tomkrikorian thanks for this contribution. As far as I can tell, this is moving the weaving from happening in the background to being a blocking operation. I'll need to test that a little as I am concerned about this making the editor unresponsive for a while, especially on larger projects.

@cla-bot
Copy link

cla-bot bot commented Nov 30, 2021

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @tomkrikorian. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

@tomkrikorian
Copy link
Contributor Author

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Nov 30, 2021

Realm welcomes all contributions! The only requirement we have is that, like many other projects, we need to have a Contributor License Agreement (CLA) in place before we can accept any external code. Our own CLA is a modified version of the Apache Software Foundation’s CLA. Our records show that CLA has not been signed by @tomkrikorian. Please submit your CLA electronically using our Google form so we can accept your submissions. After signing the CLA you can recheck this PR with a @cla-bot check comment. The GitHub usernames you file there will need to match that of your Pull Requests. If you have any questions or cannot file the CLA electronically, make a comment here and we will be happy to help you out.

@cla-bot
Copy link

cla-bot bot commented Nov 30, 2021

The cla-bot has been summoned, and re-checked this pull request!

@tomkrikorian
Copy link
Contributor Author

Hi @nirinchev, I updated my PR with the code now running the weaving in a single Task.
Running the weaving on multiple tasks was still causing the weaving errors on my side but a single Task does work in my tests.

@tomkrikorian
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Nov 30, 2021
@cla-bot
Copy link

cla-bot bot commented Nov 30, 2021

The cla-bot has been summoned, and re-checked this pull request!

@nirinchev
Copy link
Member

Nice, I like this approach better and glad it's solving your issue. I'll merge and get this released with the next minor version. I can send you a prerelease package in the meantime to unblock you.

@nirinchev nirinchev merged commit d1b3a89 into realm:master Dec 1, 2021
@tomkrikorian
Copy link
Contributor Author

Thanks @nirinchev, it's fine I'll wait for the next release :)

@tomkrikorian tomkrikorian deleted the fix/weaving-errors branch December 7, 2021 14:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Failed to weave assembly error when opening a unity project.
2 participants