Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fallback path #2766

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Added fallback path #2766

merged 4 commits into from
Jan 12, 2022

Conversation

papafe
Copy link
Contributor

@papafe papafe commented Jan 12, 2022

Added new config parameter for the fallback path where named pipes used by realm should be created.

Fixes #2751

TODO

  • Changelog entry

@cla-bot cla-bot bot added the cla: yes label Jan 12, 2022
@peppy
Copy link

peppy commented Jan 12, 2022

Since the configuration property has Fallback in its name, does this imply it will only be used in cases that creation beside the realm file fails?

One potential use case I have is wanting to always create the pipe files in a specified temporary folder to avoid compatibility issues (specifically, if a Parallels Desktop VM sees the pipe file it will seize up and require a kill -9 of the VM to recover - can be quite detrimental when a realm file is created in my home directory for whatever reason).

@papafe
Copy link
Contributor Author

papafe commented Jan 12, 2022

@peppy I agree the name is misleading, but actually if set it is used all the time.

@peppy
Copy link

peppy commented Jan 12, 2022

Thanks for confirmation and for the implementation. Should help us heaps.

@papafe papafe marked this pull request as ready for review January 12, 2022 10:26
@papafe papafe merged commit cb33c79 into master Jan 12, 2022
@papafe papafe deleted the fp/add-fallback-path branch January 12, 2022 12:46
nirinchev added a commit that referenced this pull request Jan 13, 2022
* master:
  Update CHANGELOG.md (#2767)
  Fix `TraverseSort` to support properties declared by interfaces (#2750)
  Added fallback path (#2766)
  Use lowercase "pr" for prerelease packages (#2765)
  Update README.md (#2764)
@smoogipoo
Copy link

smoogipoo commented Jan 18, 2022

Hi, I'm not sure that this is working on Linux (5.10.79-1-MANJARO). #2766 (comment) indicates that it should have an effect at all times if I understand correctly, though it still seems to create the pipe file in the original path.

We're choosing the path as follows (I've tested both as directory and as file):

string tempPathLocation = Path.Combine(Path.GetTempPath(), @"lazer");
if (!Directory.Exists(tempPathLocation))
    Directory.CreateDirectory(tempPathLocation);

As a side note, what is the expectation of the path value? A directory as I have above, or a file?

@papafe
Copy link
Contributor Author

papafe commented Jan 18, 2022

@smoogipoo I am really sorry, I gave you the wrong information because I misunderstood a piece of code. As you've noticed that path is being used only if it's not possible to create the pipe next to the realm file.

As an additional note, the fallback path should just be a directory, no need to point to a file, and should have a trailing slash

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot open realm files on vfat / exFAT filesystems on linux
4 participants