Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting primary keys during migration #2793

Merged
merged 5 commits into from
Feb 8, 2022
Merged

Conversation

nirinchev
Copy link
Member

@nirinchev nirinchev commented Jan 31, 2022

Description

Fixes #2496

TODO

  • Changelog entry
  • Tests (if applicable)

@cla-bot cla-bot bot added the cla: yes label Jan 31, 2022
@coveralls
Copy link

coveralls commented Feb 4, 2022

Pull Request Test Coverage Report for Build 1806056997

  • 8 of 9 (88.89%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 82.954%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Realm.cs 4 5 80.0%
Totals Coverage Status
Change from base Build 1795237997: -0.005%
Covered Lines: 5530
Relevant Lines: 6551

💛 - Coveralls

@nirinchev nirinchev self-assigned this Feb 7, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Yavor Georgiev <fealebenpae@users.noreply.github.com>
@nirinchev nirinchev merged commit 4864147 into main Feb 8, 2022
@nirinchev nirinchev deleted the ni/migration-setters branch February 8, 2022 13:26
nirinchev added a commit that referenced this pull request Feb 12, 2022
* main:
  Add notifications_cs.hpp to cmake lists
  Strip [UsedImplicitly] from the Remotion assembly (#2810)
  Allow setting primary keys during migration (#2793)
  fix typo (#2804)
  Remove various master references + fix up some stale docs (#2791)
  Rework handle ownership (#2795)
  Bump SharpZipLib from 1.3.2 to 1.3.3 in /Tools/SetupUnityPackage (#2798)
  Add a migration test that removes objects from the Realm (#2792)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow changing the primary key during migration
4 participants