Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make websocket error logging exceptionally verbose #3459

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Make websocket error logging exceptionally verbose #3459

merged 5 commits into from
Oct 10, 2023

Conversation

fealebenpae
Copy link
Member

No description provided.

@fealebenpae fealebenpae requested a review from nirinchev October 9, 2023 12:09
@fealebenpae fealebenpae self-assigned this Oct 9, 2023
nirinchev
nirinchev approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once stylecop is happy 👍

@coveralls-official
Copy link

coveralls-official bot commented Oct 9, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6461633605

  • 0 of 23 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 80.147%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Realm/Realm/Native/SyncSocketProvider.WebSocket.cs 0 23 0.0%
Totals Coverage Status
Change from base Build 6408544056: -0.1%
Covered Lines: 6318
Relevant Lines: 7775
💛 - Coveralls

@fealebenpae fealebenpae merged commit d13be03 into main Oct 10, 2023
@fealebenpae fealebenpae deleted the yg/ws-logging branch October 10, 2023 01:24
nirinchev added a commit that referenced this pull request Nov 1, 2023
@nirinchev
Merge branch 'main' into ni/evg-tests
a34e397 
* main:
  Small fixes to source generator (#3466)
  Make websocket error logging exceptionally verbose (#3459)
  Emit errors for collection assignments (#3456)
  Fix docfx source files (#3453)
  Fix typo (#3454)
  Add User.Changed event (#3433)
  Allow customizing json ignore attribute for serialized classes (#3451)
  Update README.md (#3450)
  Fix changelog
  Prepare for vNext (#3444)
  Prepare for 11.5.0 (#3442)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nirinchev nirinchev nirinchev approved these changes

Assignees

@fealebenpae fealebenpae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fealebenpae @nirinchev