#369 Cleanup ToList in tests #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#361 Add LINQ Count(Expression) remove ToList and use straight All<...>()>Count() - ObjectIntegrationTests.cs - SimpleTest - CreateObjectTest remove ToList and use All<...>.Where(...).Count() SimpelLINQtests.cs - CreateList replace All<...>.Where(...).Count() with All<...>.Count(...) SimpleLINQtests.cs - CountFoundItems - CountWithNot replace realm.All<...>().Where( ...).ToList().First() with .All<...>().First(...) - RelationshipTests.cs - TimHasATopDog - TimHasTwoIterableDogs - TimHasTwoIterableDogsListed - TimsIterableDogsThrowExceptions - TimRetiredHisTopDog - TimAddsADogLater - DaniHasNoTopDog replace realm.All<...>().Where( ...).ToList().First() with .All<...>().Single(...) - RelationshipTests.cs - TimAddsADogByInsert - TimLosesHisDogsByOrder - TimLosesHisDogsInOneClear - TimLosesBilbo - TestExceptionsFromTimsDogsOutOfRange replace realm.All<...>().Where( ...).ToList()[0] with .All<...>().First(...) - ObjectIntegrationTests.cs - ReadAndWriteEqualityTest replace realm.All<...>().Where( ...).ToList().First() with .All<...>().Where(...).First() - RelationshipTests.cs - DaniHasNoTopDog - TestExceptionsFromEmptyListOutOfRange replace realm.All<...>().Where( ...).ToList().First() with .All<...>().Where(...).First() - RelationshipTests.cs - DaniHasNoDogs - TestExceptionsFromIteratingEmptyList replace realm.All<...>().Where( ...).ToList().Count with .All<...>().Count(...) - TestManagingStandaloneThreeLevelRelationship - TestCircularRelationshipsFromStandaloneTwoStage RealmResultsVisitor.cs - RecurseToWhereOrRunLambda added - VisitMethodCall - handle Count, Single and First with no lambda argument, using RecurseToWhereOrRunLambda TODO NonAutomaticPropertiesShouldBeIgnored _realm.All<Person>().ToList().Single() to straight _realm.All<Person>().Single()
Added documentation
|
👍 |
AndyDentFree
added a commit
that referenced
this pull request
Mar 4, 2016
#369 Cleanup ToList in tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes #361 Add LINQ Count(Expression)
remove ToList and use straight All<...>()>Count()
remove ToList and use All<...>.Where(...).Count()
SimpelLINQtests.cs
replace All<...>.Where(...).Count() with All<...>.Count(...)
SimpleLINQtests.cs
replace realm.All<...>().Where( ...).ToList().First() with .All<...>().First(...)
replace realm.All<...>().Where( ...).ToList().First() with .All<...>().Single(...)
replace realm.All<...>().Where( ...).ToList()[0] with .All<...>().First(...)
replace realm.All<...>().Where( ...).ToList().First() with .All<...>().Where(...).First()
replace realm.All<...>().Where( ...).ToList().First() with .All<...>().Where(...).First()
replace realm.All<...>().Where( ...).ToList().Count with .All<...>().Count(...)
RealmResultsVisitor.cs
TODO
NonAutomaticPropertiesShouldBeIgnored
_realm.All().ToList().Single() to straight
_realm.All().Single()