Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add weaver warning when applying realm attributes to non-persisted properties #882

Merged
merged 2 commits into from
Oct 25, 2016
Merged

Add weaver warning when applying realm attributes to non-persisted properties #882

merged 2 commits into from
Oct 25, 2016

Conversation

nirinchev
Copy link
Member

@kristiandupont @fealebenpae do you think this should be a warning or an error?

Resolves #870

@nirinchev nirinchev added this to the v1.0 milestone Oct 24, 2016
kristiandupont
kristiandupont suggested changes Oct 24, 2016
View reviewed changes
Copy link
Contributor

@kristiandupont kristiandupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer them to be error messages. The only valid situation I can imagine is where you are temporarily not persisting some property while developing, but then you should be able to type the two slashes in front of the attribute.

@nirinchev
Copy link
Member Author

Ping @kristiandupont @fealebenpae

@nirinchev nirinchev merged commit ef84aa5 into master Oct 25, 2016
@nirinchev nirinchev deleted the ni/attribute-warnings branch October 25, 2016 15:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kristiandupont kristiandupont kristiandupont requested changes

@fealebenpae fealebenpae fealebenpae approved these changes

Assignees

@fealebenpae fealebenpae

@kristiandupont kristiandupont

@nirinchev nirinchev

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nirinchev @fealebenpae @kristiandupont