-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and cleanup for version 11. #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just read through a bit of the code. I'll give this a more thorough review when it's marked as ready. But really, awesome work so far. I think the community will really appreciate this, and hopefully also start making their own PRs for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding some comments while those are fresh on my mind.
8502cd3
to
3f036e3
Compare
3f036e3
to
fdd81eb
Compare
@@ -42,8 +42,8 @@ | |||
"realm": ">=10.0.0" | |||
}, | |||
"dependencies": { | |||
"react-native-flipper": ">=0.162.0", | |||
"realm": ">=10.20.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am removing realm as a dependency... pretty sure all of this is meant to be peer dependencies rather than dependencies and I am trying to minimize unnecessary ones. I think react-native-flipper can be moved as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these should all be peerDependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work. Thanks for the tour of the flipper code :)
I have a few comments/suggestions/questions, but nothing holding this back.
@@ -42,8 +42,8 @@ | |||
"realm": ">=10.0.0" | |||
}, | |||
"dependencies": { | |||
"react-native-flipper": ">=0.162.0", | |||
"realm": ">=10.20.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these should all be peerDependencies
This is a rather large refactor that mainly does the following:
General:
/realm-flipper-plugin-device - Device library
Listener.ts
=>PluginConnectedObjects.ts
_objectKey
field being used for serialized objects renamed to_pluginObjectKey
to avoid conflicts with Realm function but should likely be changed completely in future implementation. See #86 and #121./flipper-plugin-realm - Desktop plugin
realm
as a dev dependency so the underlying types used by the desktop plugin extend Realm classes (thus making it easier to notice i.e. breaking changes or other conflicts in future releases)./testApp - Plugin test application
testApp/flipperTest
directory, the rest is just regular template code.