Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building SDK with JVM 11 #7535

Merged
merged 43 commits into from
Nov 16, 2021
Merged

Support building SDK with JVM 11 #7535

merged 43 commits into from
Nov 16, 2021

Conversation

rorbech
Copy link
Contributor

@rorbech rorbech commented Aug 3, 2021

Closes #7533
Closes #7179
Closes #7474 - Separated the actual fix of this into it's own PR in #7525

TODO

@cmelchior
Copy link
Contributor

Upgrading might be problematic due to https://issuetracker.google.com/issues/187134648. I have not yet been able to determine if there is a work-around.

@cla-bot cla-bot bot added the cla: yes label Nov 1, 2021
@cmelchior cmelchior force-pushed the cr/fix-java11-build-errors branch 4 times, most recently from 5b1b19c to bd369fd Compare November 11, 2021 23:07
@cmelchior cmelchior force-pushed the cr/fix-java11-build-errors branch from bd369fd to 7a3de62 Compare November 11, 2021 23:12
@cmelchior
Copy link
Contributor

Currently blocked on https://issuetracker.google.com/issues/202985154

@cmelchior cmelchior marked this pull request as ready for review November 15, 2021 11:46
@cmelchior
Copy link
Contributor

cmelchior commented Nov 15, 2021

Finally, ready for review. I disabled us building for Java 8 for now, as fixing that will grow this PR even more, and it is already kinda too big.

Note. Most changes to the realm-transformer was introduced and reviewed already in #7566

@cmelchior cmelchior self-assigned this Nov 15, 2021
Copy link
Collaborator

@clementetb clementetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except that AS fails to build on task: :realm-library:buildCMakeRelWithDebInfo[x86_64][realm-jni].

The build mode RelWithDebInfo messes CMakeLists include directory path.

AS 2021.1.1 (bumblebee) is now required.

Jenkinsfile Outdated Show resolved Hide resolved
# Conflicts:
#	CHANGELOG.md
#	realm/realm-library/src/androidTestObjectServer/kotlin/io/realm/mongodb/sync/SyncConfigurationTests.kt
@cmelchior cmelchior requested a review from clementetb November 16, 2021 12:32
Copy link
Collaborator

@clementetb clementetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

@cmelchior cmelchior merged commit 0c37e9a into master Nov 16, 2021
@cmelchior cmelchior deleted the cr/fix-java11-build-errors branch November 16, 2021 14:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants