-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building SDK with JVM 11 #7535
Conversation
Upgrading might be problematic due to https://issuetracker.google.com/issues/187134648. I have not yet been able to determine if there is a work-around. |
# Conflicts: # CHANGELOG.md
5b1b19c
to
bd369fd
Compare
bd369fd
to
7a3de62
Compare
Currently blocked on https://issuetracker.google.com/issues/202985154 |
Finally, ready for review. I disabled us building for Java 8 for now, as fixing that will grow this PR even more, and it is already kinda too big. Note. Most changes to the realm-transformer was introduced and reviewed already in #7566 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except that AS fails to build on task: :realm-library:buildCMakeRelWithDebInfo[x86_64][realm-jni]
.
The build mode RelWithDebInfo
messes CMakeLists include directory path.
AS 2021.1.1 (bumblebee) is now required.
# Conflicts: # CHANGELOG.md # realm/realm-library/src/androidTestObjectServer/kotlin/io/realm/mongodb/sync/SyncConfigurationTests.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🚀
Closes #7533
Closes #7179
Closes #7474 - Separated the actual fix of this into it's own PR in #7525
TODO
This also include doing work on CI so we e.g. compile the introExample with both Java 8 and Java 11 to catch future regressions. Compile with JDK11 #7539