Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable dead code elimination #757

Merged
merged 2 commits into from
Dec 21, 2016
Merged

Disable dead code elimination #757

merged 2 commits into from
Dec 21, 2016

Conversation

kristiandupont
Copy link
Contributor

@kristiandupont kristiandupont commented Dec 21, 2016 •
edited
Loading

This fixes the linker error that we've started seeing, probably because of xcode versioning:

Undefined symbols for architecture i386:
1581 	  "_RCTSetLogFunction", referenced from:
1582 	      -[RealmReactTests invokeTest] in RealmReactTests.o
1583 	  "_RCTAddLogFunction", referenced from:
1584 	      +[RealmReactTests load] in RealmReactTests.o

@kristiandupont kristiandupont self-assigned this Dec 21, 2016
@kristiandupont kristiandupont merged commit 5684fd5 into master Dec 21, 2016
@kristiandupont kristiandupont deleted the kd/disable-dead-code-elimination branch December 21, 2016 15:27
@mrackwitz
Copy link
Contributor

Shouldn't we rather use -force_load when linking Realm on iOS instead of forcing our users to disable DEAD_CODE_STRIPPING for the whole target?

@fealebenpae
Copy link
Member

It seems to be the favored solution according to facebook/react-native#2685. Besides, the symbols the linker complains about come from libReact.a and shouldn't be affected by how Realm is linked into the target.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fealebenpae fealebenpae fealebenpae approved these changes

Assignees

@kristiandupont kristiandupont

Labels
T-Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristiandupont @mrackwitz @fealebenpae