Fix sub-querying on a RealmResults ignores the original filter #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
approved these changes
Sep 26, 2022
CHANGELOG.md
Outdated
| @@ -9,6 +9,7 @@ | |||
| ### Fixed | |||
| * Classes using `RealmObject` or `EmbeddedRealmObject` as a generics type would be modified by the compiler plugin causing compilation errors. (Issue [981] (https://github.com/realm/realm-kotlin/issues/981)) | |||
| * Ordering not respected for `RealmQuery.first()`. (Issue [#953](https://github.com/realm/realm-kotlin/issues/953)) | |||
| * Sub-querying on a RealmResults ignores the original filter. (Issue [#998](https://github.com/realm/realm-kotlin/pull/998)) | |||
There was a problem hiding this comment.
We should also add a line of text to Breaking Changes.
cmelchior
approved these changes
Sep 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sub-querying on RealmResults ignores the original filter.
It also changes the return type of
RealmResults::queryfromRealmResultstoRealmQuery.