Add parent access support on embedded objects #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # packages/library-base/src/commonMain/kotlin/io/realm/kotlin/internal/ConfigurationImpl.kt # packages/library-base/src/commonMain/kotlin/io/realm/kotlin/internal/InternalConfiguration.kt
cmelchior
approved these changes
Nov 28, 2022
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/ext/BacklinksExt.kt
Outdated
Show resolved
Hide resolved
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/ext/BacklinksExt.kt
Outdated
Show resolved
Hide resolved
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/ext/BacklinksExt.kt
Outdated
Show resolved
Hide resolved
...t-base/src/androidAndroidTest/kotlin/io/realm/kotlin/test/shared/EmbeddedRealmObjectTests.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
…t/BacklinksExt.kt Co-authored-by: Christian Melchior <christian@ilios.dk>
…m-kotlin into ct/backlinks-embedded-objects
|
Added support for defining backlinks on |
edualonso
approved these changes
Dec 13, 2022
cmelchior
approved these changes
Dec 19, 2022
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/ext/EmbeddedRealmObjectExt.kt
Outdated
Show resolved
Hide resolved
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/ext/EmbeddedRealmObjectExt.kt
Outdated
Show resolved
Hide resolved
packages/library-base/src/commonMain/kotlin/io/realm/kotlin/internal/BacklinksDelegateImpl.kt
Outdated
Show resolved
Hide resolved
| @@ -844,7 +846,8 @@ class AccessorModifierIrGeneration(private val pluginContext: IrPluginContext) { | |||
| private fun IrType.isLinkingObject(): Boolean { | |||
| val propertyClassId = this.classifierOrFail.descriptor.classId | |||
| val realmBacklinksClassId = realmBacklinksClass.descriptor.classId | |||
| return propertyClassId == realmBacklinksClassId | |||
| val realmEmbeddedBacklinksClassId = realmEmbeddedBacklinksClass.descriptor.classId | |||
| return propertyClassId == realmBacklinksClassId || propertyClassId == realmEmbeddedBacklinksClassId | |||
There was a problem hiding this comment.
Not sure I get this? Is realmBacklinksClassId boolean? Would be nice to have the types be part of the properties in this method.
There was a problem hiding this comment.
realmBacklinksClassId isn't a boolean but a ClassId?. I am going to split the comparison into two methods for clarity.
…t/EmbeddedRealmObjectExt.kt Co-authored-by: Christian Melchior <christian@ilios.dk>
…t/EmbeddedRealmObjectExt.kt Co-authored-by: Christian Melchior <christian@ilios.dk>
# Conflicts: # CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add backlinks support for embedded objects through the
EmbeddedRealmObject.parent()extension function.It provides access to the parent in runtime, and does not require defining particular property in the model as we need in
backlinks.closes #1134