Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignoring delegated properties #1386

Merged
merged 5 commits into from
May 16, 2023

Conversation

clementetb
Copy link
Contributor

@clementetb clementetb commented May 9, 2023

Delegated properties did not support the @Ignore annotation. This was preventing the users to write their own custom delegated properties.

This would help users to write delegates on Realm types to do any conversion to their own custom types.

#closes #1381

@clementetb clementetb self-assigned this May 9, 2023
@cla-bot cla-bot bot added the cla: yes label May 9, 2023
Copy link
Contributor

@cmelchior cmelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -1,3 +1,31 @@
## 1.8.1-SNAPSHOT (YYYY-MM-DD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 1.9.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ok, this PR should target releases.

Co-authored-by: Christian Melchior <christian@ilios.dk>
@clementetb clementetb changed the base branch from main to releases May 11, 2023 08:21
@clementetb clementetb marked this pull request as ready for review May 11, 2023 08:22
@clementetb clementetb merged commit 2dae79e into releases May 16, 2023
@clementetb clementetb deleted the ct/support-ignore-delegated-properties branch May 16, 2023 08:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Delegated properties in Realm objects
2 participants