Use async open for FLX Realms #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2023 09:24
Fix bug causing async open to run every time
|
Perhaps can be used, but even then a test like this should be run in isolation from the rest. |
rorbech
approved these changes
Jun 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1438
I also discovered that we didn't check whether a realm file existed or not before triggering
waitForInitialRemoteData, this meant that ifwaitForInitialRemoteDatawas enabled, the device would always require a network connection before opening the realm file, even after being opened for the first time.It isn't really possible to write a test for this since it would require us to be able to cut the internet connection between opening the Realm for the first and second time. But I verified the behavior manually.