Skip to content
This repository has been archived by the owner on Mar 2, 2023. It is now read-only.

Cache-based schema lookups and sub-module based refactoring #14

Merged
merged 6 commits into from
Sep 20, 2022
Merged

Cache-based schema lookups and sub-module based refactoring #14

merged 6 commits into from
Sep 20, 2022

Conversation

gagik
Copy link
Contributor

@gagik gagik commented Sep 19, 2022 •
edited
Loading

  1. Changes setters and getters of Realm Object to a cache based approach.
  2. Changes create functionality of Results and Objects to a more OOP-based organization.
  3. Refactor notifications into a separate file in C.
  4. Combines all transaction functions into write.

elle-j
elle-j approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/realm/object.lua Outdated Show resolved Hide resolved
lib/realm/results.lua Outdated Show resolved Hide resolved
gagik and others added 2 commits September 19, 2022 16:55
@gagik @elle-j
Update lib/realm/results.lua
9f77fc5 
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
@gagik @elle-j
Update lib/realm/object.lua
c16b30a 
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
@gagik gagik merged commit f4126a8 into main Sep 20, 2022
@gagik gagik deleted the gagik/cache-schema branch September 20, 2022 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elle-j elle-j elle-j approved these changes

@JacobOscarGunnarsson JacobOscarGunnarsson JacobOscarGunnarsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gagik @JacobOscarGunnarsson @elle-j