Rename DomainBlacklist rule

realodix · May 4, 2024 · bc5b248 · bc5b248
1 parent dd24163
commit bc5b248
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/app/Http/Requests/StoreUrlRequest.php b/app/Http/Requests/StoreUrlRequest.php
@@ -3,7 +3,7 @@
 namespace App\Http\Requests;
 
 use App\Rules\AlphaNumHyphen;
-use App\Rules\Url\DomainBlacklist;
+use App\Rules\Url\NotBlacklistedDomain;
 use Illuminate\Foundation\Http\FormRequest;
 
 class StoreUrlRequest extends FormRequest
@@ -26,7 +26,7 @@ public function authorize()
     public function rules()
     {
         return [
-            'long_url'   => ['required', 'url', 'max:65535', new DomainBlacklist],
+            'long_url'   => ['required', 'url', 'max:65535', new NotBlacklistedDomain],
             'custom_key' => ['nullable', 'max:20', new AlphaNumHyphen, 'unique:urls,keyword'],
         ];
     }

diff --git a/app/Http/Requests/UpdateUrlRequest.php b/app/Http/Requests/UpdateUrlRequest.php
@@ -3,7 +3,7 @@
 namespace App\Http\Requests;
 
 use App\Models\Url;
-use App\Rules\Url\DomainBlacklist;
+use App\Rules\Url\NotBlacklistedDomain;
 use Illuminate\Foundation\Http\FormRequest;
 
 class UpdateUrlRequest extends FormRequest
@@ -27,7 +27,7 @@ public function rules(): array
 
         return [
             'title'    => ["max:{$titleLength}"],
-            'long_url' => ['required', 'url', 'max:65535', new DomainBlacklist],
+            'long_url' => ['required', 'url', 'max:65535', new NotBlacklistedDomain],
         ];
     }
 }
diff --git a/app/Rules/Url/DomainBlacklist.php → app/Rules/Url/NotBlacklistedDomain.php b/app/Rules/Url/DomainBlacklist.php → app/Rules/Url/NotBlacklistedDomain.php
@@ -5,7 +5,7 @@
 use App\Helpers\Helper;
 use Illuminate\Contracts\Validation\ValidationRule;
 
-class DomainBlacklist implements ValidationRule
+class NotBlacklistedDomain implements ValidationRule
 {
     /**
      * Run the validation rule.

diff --git a/tests/Unit/Rule/UrlTest.php b/tests/Unit/Rule/UrlTest.php
@@ -2,8 +2,8 @@
 
 namespace Tests\Unit\Rule;
 
-use App\Rules\Url\DomainBlacklist;
 use App\Rules\Url\KeywordBlacklist;
+use App\Rules\Url\NotBlacklistedDomain;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\Test;
@@ -27,7 +27,7 @@ protected function setUp(): void
     #[DataProvider('domainBlacklistPassDataProvider')]
     public function domainBlacklistPass($value): void
     {
-        $val = Helper::validator(['foo' => $value], ['foo' => new DomainBlacklist]);
+        $val = Helper::validator(['foo' => $value], ['foo' => new NotBlacklistedDomain]);
 
         $this->assertTrue($val->passes());
         $this->assertSame([], $val->messages()->messages());
@@ -41,7 +41,7 @@ public function domainBlacklistPass($value): void
     #[DataProvider('domainBlacklistFailDataProvider')]
     public function domainBlacklistFail($value): void
     {
-        $val = Helper::validator(['foo' => $value], ['foo' => new DomainBlacklist]);
+        $val = Helper::validator(['foo' => $value], ['foo' => new NotBlacklistedDomain]);
 
         $this->assertTrue($val->fails());
         $this->assertSame([